Added Otel collector to docker compose to ease the setup #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sat-devopsnow
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
This looks good!
In our latest K8s agent, we use v0.56.0: https://github.com/devops-machine/charts/blob/main/src/observe-agent/values.yaml#L39
... and with that version, the command args remove the mem-ballast option: https://github.com/devops-machine/charts/blob/main/src/observe-agent/templates/otel-collector-deployment.yaml#L50
So to make it in line with latest, you can make those two tweaks... But otherwise okay as-is!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the setup and running of the otel collector very easy.