additional invariant culture checks for lower case

Orbmu2k · Mar 26, 2023 · 3c74a9b · 3c74a9b
1 parent 70c63b1
commit 3c74a9b
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 12 deletions.
diff --git a/nspector/Common/DrsDecrypterService.cs b/nspector/Common/DrsDecrypterService.cs
@@ -89,7 +89,7 @@ public void DecryptSettingIfNeeded(string profileName, ref NVDRS_SETTING setting
 
         private string FormatInternalSettingKey(string profileName, uint settingId)
         {
-            return profileName + settingId.ToString("X8").ToLower();
+            return profileName + settingId.ToString("X8").ToLowerInvariant();
         }
 
         public bool IsInternalSetting(string profileName, uint settingId)

diff --git a/nspector/Common/DrsScannerService.cs b/nspector/Common/DrsScannerService.cs
@@ -198,7 +198,7 @@ private void AddScannedSettingToCache(NVDRS_PROFILE profile, NVDRS_SETTING setti
 
         public string FindProfilesUsingApplication(string applicationName)
         {
-            string lowerApplicationName = applicationName.ToLower();
+            string lowerApplicationName = applicationName.ToLowerInvariant();
             string tmpfile = TempFile.GetTempFileName();
 
             try
@@ -219,7 +219,7 @@ public string FindProfilesUsingApplication(string applicationName)
                         string scope = m.Result("${scope}");
                         foreach (Match ms in Regex.Matches(scope, "Executable\\s\\\"(?<app>.*?)\\\"", RegexOptions.Singleline))
                         {
-                            if (ms.Result("${app}").ToLower() == lowerApplicationName)
+                            if (ms.Result("${app}").ToLowerInvariant() == lowerApplicationName)
                             {
                                 matchingProfiles.Add(m.Result("${profile}"));
                             }

diff --git a/nspector/Common/DrsUtil.cs b/nspector/Common/DrsUtil.cs
@@ -17,7 +17,7 @@ public static string GetDwordString(uint dword)
         public static uint ParseDwordByInputSafe(string input)
         {
             uint result = 0;
-            if (input.ToLower().StartsWith("0x"))
+            if (input.ToLowerInvariant().StartsWith("0x"))
             {
                 try
                 {

diff --git a/nspector/Common/Helper/ShortcutResolver.cs b/nspector/Common/Helper/ShortcutResolver.cs
@@ -30,7 +30,7 @@ public static string ResolveExecuteable(string filename, out string profileName)
 
             try
             {
-                switch (fileInfo.Extension.ToLower())
+                switch (fileInfo.Extension.ToLowerInvariant())
                 {
                     case ".lnk": return ResolveFromShellLinkFile(fileInfo.FullName);
                     case ".url": return ResolveFromUrlFile(fileInfo.FullName);
@@ -54,7 +54,7 @@ private static string ResolveFromShellLinkFile(string filename)
             }
 
             var targetInfo = new FileInfo(shellLink.Target);
-            if (targetInfo.Name.ToLower() == SteamAppResolver.SteamExeName)
+            if (targetInfo.Name.ToLowerInvariant() == SteamAppResolver.SteamExeName)
             {
                 if (shellLink.Arguments.Contains(SteamAppResolver.SteamArgumentPattern))
                 {
@@ -63,7 +63,7 @@ private static string ResolveFromShellLinkFile(string filename)
                 }
             }
 
-            if (targetInfo.Extension.ToLower().Equals(".exe"))
+            if (targetInfo.Extension.ToLowerInvariant().Equals(".exe"))
             {
                 return targetInfo.Name;
             }

diff --git a/nspector/Program.cs b/nspector/Program.cs
@@ -35,7 +35,7 @@ static void Main(string[] args)
             if (argFileIndex != -1)
             {
 
-                if (new FileInfo(args[argFileIndex]).Extension.ToLower() == ".nip")
+                if (new FileInfo(args[argFileIndex]).Extension.ToLowerInvariant() == ".nip")
                 {
                     try
                     {

diff --git a/nspector/frmBitEditor.cs b/nspector/frmBitEditor.cs
@@ -76,7 +76,7 @@ private void SplitBitsFromUnknownSettings()
                                 {
                                     for (int f = 0; f < filters.Length; f++)
                                     {
-                                        if (settingProfileNames[p].ToLower().Contains(filters[f].ToLower()))
+                                        if (settingProfileNames[p].ToLowerInvariant().Contains(filters[f].ToLower()))
                                         {
                                             profileNames += settingProfileNames[p] + ",";
                                         }

diff --git a/nspector/frmDrvSettings.cs b/nspector/frmDrvSettings.cs
@@ -1158,7 +1158,7 @@ private void lvSettings_OnDropFilesNative(string[] files)
             if (files.Length == 1)
             {
                 var fileInfo = new FileInfo(files[0]);
-                if (fileInfo.Extension.ToLower().Equals(".nip"))
+                if (fileInfo.Extension.ToLowerInvariant().Equals(".nip"))
                 {
                     ImportProfiles(fileInfo.FullName);
                     return;
@@ -1295,11 +1295,11 @@ private void SearchSetting()
             string inputString = "";
             if (InputBox.Show("Search Setting", "Please enter setting name:", ref inputString, new List<string>(), "", 2048) == System.Windows.Forms.DialogResult.OK)
             {
-                var lowerInput = inputString.Trim().ToLower();
+                var lowerInput = inputString.Trim().ToLowerInvariant();
                 lvSettings.BeginUpdate();
                 foreach(ListViewItem itm in lvSettings.Items)
                 {
-                    if (!itm.Text.ToLower().Contains(lowerInput))
+                    if (!itm.Text.ToLowerInvariant().Contains(lowerInput))
                     {
                         itm.Remove();
                     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -35,7 +35,7 @@ static void Main(string[] args) @@
                 if (argFileIndex != -1)
                 {
-                    if (new FileInfo(args[argFileIndex]).Extension.ToLower() == ".nip")
+                    if (new FileInfo(args[argFileIndex]).Extension.ToLowerInvariant() == ".nip")
                     {
                         try
                         {
@@ Expand Down @@