Fixing async issues in OrchardCore.Tests (Lombiq Technologies: OCORE-80) #11195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piedone
commented
Feb 16, 2022
Comment on lines
+151
to
+154
| if (methodHasParams && (methodParameters.Length - args.Count == 1) && !lastParameterIsParams) | ||
| { | ||
| invokeParameters.Add(new string[] { }); | ||
| } |
There was a problem hiding this comment.
I'm really not sure why this logic was there. However, adding a second string[] argument to a method invocation that has a params parameter (in addition to an already added string[] argument on line 131) seems like a no-go in any case.
jtkech
approved these changes
Feb 16, 2022
|
Hmm, the CLA check didn't run. I've asked about this here: dotnet-foundation/website#1086. However, since I have the CLA signed since the dawn of time, I'll just go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under #11194 I've noticed (well, the analyzers that I've accidentally added noticed, really) several async issues in the tests. After fixing them, one of the tests failed, which I'm fixing here too.