Add in a mailing system for fetching failed CV #3189
Conversation
lamtu1
added
Enhancement
Priority - High
lamtu1
force-pushed
the
feature/notificationFetchFail
branch
from
b26bbe2 to
ac82f59
Compare
|
|
||
| # GET: Get the id from the txt file and send email to both user and metadata team | ||
| pid = filename.to_s.gsub('.txt', '') | ||
| work = ActiveFedora::Base.find(pid) |
There was a problem hiding this comment.
SolrDocument should have the depositor
app/workers/fetch_graph_worker.rb
Outdated
| path = "./tmp/failed_fetch/#{pid}.txt" | ||
|
|
||
| # SEARCH: Look for works to create a link | ||
| work = ActiveFedora::Base.find(pid) |
There was a problem hiding this comment.
I'm pretty sure you can find the path w/ a solr document, that would be faster.
| puts 'Running OregonDigital::FailedFetchNotification' | ||
|
|
||
| # MAILER: Disable mailer so Failed Fetch won't send out email while running check | ||
| ActionMailer::Base.perform_deliveries = false |
There was a problem hiding this comment.
Shouldn't need to disable and re-enable delivery, right?
| @@ -0,0 +1,13 @@ | |||
| # frozen_string_literal:true | |||
There was a problem hiding this comment.
Could we get some more specs, particularly dealing with storing and retrieving stuff in ./tmp?
|
|
||
| require 'zip' | ||
|
|
||
| namespace :oregon_digital do |
There was a problem hiding this comment.
Maybe we can use a similar architecture to Linda's review queue daily notification solution? #1562 #3237
A single file can just store the pids and we use a helper lib object to fetch the solrdocs for the pids, generate a user map & batch all the emails together per user.
A running batch could create a list of pid/links for the metadeities .
It would help on disk clutter, simplify #store_failed_fetch, speed up individual lookups (SolrDocument.find can take many pids at once), and keep code consistency
app/workers/fetch_graph_worker.rb
Outdated
|
|
||
| # TODO: WILL INTEGRATE THIS WHEN REDOING EMAILING FOR THESE JOBS | ||
| # def fetch_failed_callback(user, val) | ||
| # Hyrax.config.callback.run(:ld_fetch_failure, user, val.rdf_subject.value) | ||
| # end | ||
|
|
||
| def fetch_failed_graph(val) | ||
| def fetch_failed_graph(val, _pid) |
lamtu1
force-pushed
the
feature/notificationFetchFail
branch
from
97508bd to
931e400
Compare
FEATURE:Add in a mailer to the fetch failed for Graph Worker on theCVand report to theuserandmetadatateam.fixes #1560
NOTE:Need to ask about the idea of(For now, just focus on the sending capability and can work on enhancement later on)institutionon this ticket to separate the out the failed fetch notify