MyPy fixes #1532
Merged
MyPy fixes #1532
+305
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sdba
|
This is failing due to changes in Pandas-related time signature codes. See: #1534 |
aulemahal
approved these changes
Nov 23, 2023
Comment on lines
+333
to
+335
| categories: list[str] | None = None, | ||
| ops: list[tuple[str, str]] | None = None, | ||
| thresholds: list[tuple[float, float]] | None = None, |
There was a problem hiding this comment.
Is this because MyPy doesn't like complex default values ?
There was a problem hiding this comment.
It's not so much that it's complex values, it's because those values are treated as mutable objects. It's very easy for a user developer to accidentally modify the default arguments during calls, leading to weird behaviour when called again.
https://stackoverflow.com/questions/1132941/least-astonishment-and-the-mutable-default-argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
mypytyping errorsDoes this PR introduce a breaking change?
No, but some call signatures are changed (more precise).
Other information:
https://mypy.readthedocs.io/en/stable/index.html