Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid FutureWarning for dt.week #1964

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Avoid FutureWarning for dt.week #1964

merged 3 commits into from
Oct 17, 2024

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Changes the dt.week call to dt.isocalendar().week to avoid an (ancient) FutureWarning from xarray.

Does this PR introduce a breaking change?

No. all xarray versions we support have the isocalender() accessor.

Other information:

@Zeitsperre Zeitsperre requested a review from coxipi October 17, 2024 18:20
@aulemahal aulemahal requested review from Zeitsperre and removed request for Zeitsperre October 17, 2024 18:23
@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Oct 17, 2024
@Zeitsperre Zeitsperre mentioned this pull request Oct 17, 2024
Merged
5 tasks
@Zeitsperre Zeitsperre added the priority Immediate priority label Oct 17, 2024
@Zeitsperre Zeitsperre force-pushed the avoid-dt.week-warning branch 2 times, most recently from 3dc5790 to 3e24c0f Compare October 17, 2024 18:54
coxipi
coxipi approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@coxipi coxipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@github-actions github-actions bot added the approved Approved for additional tests label Oct 17, 2024
@Zeitsperre Zeitsperre force-pushed the avoid-dt.week-warning branch from 3e24c0f to 27ec95f Compare October 17, 2024 19:36
@Zeitsperre Zeitsperre force-pushed the avoid-dt.week-warning branch from 27ec95f to b7e8716 Compare October 17, 2024 19:36
@Zeitsperre Zeitsperre merged commit 5562ac7 into main Oct 17, 2024
21 checks passed
@Zeitsperre Zeitsperre deleted the avoid-dt.week-warning branch October 17, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coxipi coxipi coxipi approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests priority Immediate priority sdba Issues concerning the sdba submodule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aulemahal @coxipi @Zeitsperre