Skip to content

Commit

Permalink
ROU-4744: updating Data Grid configs (#393)
Browse files Browse the repository at this point in the history
This PR is for updating the configurations of the Data Grid, to change
how the docs and the compilation are done.

### What was happening
* The configurations were outdated and inconsistent with OutSystems UI
repo

### What was done
* Updated the configs to match OutSystems UI
* Updated versions of dev libraries

### Checklist
* [x] tested locally
* [ ] documented the code
* [x] clean all warnings and errors of eslint
* [ ] requires changes in OutSystems (if so, provide a module with
changes)
* [ ] requires new sample page in OutSystems (if so, provide a module
with changes)
  • Loading branch information
rugoncalves authored Jan 29, 2024
2 parents 1974f49 + a8bfbef commit fd6f0ac
Show file tree
Hide file tree
Showing 26 changed files with 4,171 additions and 5,641 deletions.
4 changes: 3 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,6 @@ dist
# don't lint libraries
src/libraries/**
*.d.ts
*.js
*.js
# don't lint settings
*.snyk
110 changes: 73 additions & 37 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,96 +8,129 @@
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"prettier/@typescript-eslint", // Uses eslint-config-prettier to disable ESLint rules from @typescript-eslint/eslint-plugin that would conflict with prettier
"plugin:prettier/recommended" // Enables eslint-plugin-prettier and eslint-config-prettier. This will display prettier errors as ESLint errors. Make sure this is always the last configuration in the extends array.
"prettier"
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 12
},
"plugins": ["@typescript-eslint", "prettier"],
"plugins": [
"@typescript-eslint",
"prettier"
],
"rules": {
"@typescript-eslint/member-ordering": [
"warn",
{
"default": {
"memberTypes": [
"signature",
"field",
"signature",
"field",
"method"
],
],
"order": "alphabetically"
},
"interfaces": {
"memberTypes": [
"signature",
"field",
"field",
"method"
],
"order": "alphabetically"
},
"classes": {
"memberTypes": [
"signature",
"private-field",
"signature",
"private-field",
"protected-field",
"public-field",
"constructor",
"private-method",
"protected-method",
"public-method",
"public-field",
"constructor",
"private-method",
"protected-method",
"public-method",
"abstract-method"
],
],
"order": "alphabetically"
}
}
}
],
"@typescript-eslint/explicit-member-accessibility": [
"warn",
{
"ignoredMethodNames": ["constructor"]
"ignoredMethodNames": [
"constructor"
]
}
],
"@typescript-eslint/naming-convention": [
"error",
{
"selector": "function",
"format": ["StrictPascalCase"],
"modifiers": ["exported"]
"format": [
"StrictPascalCase"
],
"modifiers": [
"exported"
]
},
{
"selector": "class",
"format": ["StrictPascalCase"]
"selector": "class",
"format": [
"StrictPascalCase"
]
},
{
"selector": "classProperty",
"format": ["strictCamelCase"],
"format": [
"strictCamelCase"
],
"leadingUnderscore": "require",
"modifiers": ["private"]
"modifiers": [
"private"
]
},
{
"selector": "classProperty",
"format": ["strictCamelCase"],
"format": [
"strictCamelCase"
],
"leadingUnderscore": "forbid",
"modifiers": ["public", "protected"]
"modifiers": [
"public",
"protected"
]
},
{
"selector": "classMethod",
"format": ["strictCamelCase"],
"format": [
"strictCamelCase"
],
"leadingUnderscore": "require",
"modifiers": ["private"]
"modifiers": [
"private"
]
},
{
"selector": "classMethod",
"format": ["strictCamelCase"],
"format": [
"strictCamelCase"
],
"leadingUnderscore": "forbid",
"modifiers": ["public", "protected"]
"modifiers": [
"public",
"protected"
]
},
{
"selector": "interface",
"format": ["UPPER_CASE", "StrictPascalCase"],
"prefix": ["I"]
}
"format": [
"UPPER_CASE",
"StrictPascalCase"
],
"prefix": [
"I"
]
}
],
"@typescript-eslint/no-empty-interface": "off",
"@typescript-eslint/no-namespace": "off",
Expand All @@ -110,10 +143,10 @@
"no-extend-native": "error",
"no-inner-declarations": "off",
"no-multiple-empty-lines": [
"warn",
{
"max": 1,
"maxEOF": 0
"warn",
{
"max": 1,
"maxEOF": 0
}
],
"no-template-curly-in-string": "warn",
Expand All @@ -122,7 +155,10 @@
"no-prototype-builtins": "off",
//"no-use-before-define": "error",
"no-var": "error",
"one-var": ["warn", "never"],
"one-var": [
"warn",
"never"
],
//"quotes": ["error", "single"], //ecaping quotes on prettier https://github.com/prettier/prettier/issues/973
"semi": [
"error",
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ dist

/*.bat


docs/
11 changes: 8 additions & 3 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/* prettier-ignore */
*.md
*.d.ts
dist
dependencies
node_modules

*.css

# don't lint settings
*.snyk
11 changes: 7 additions & 4 deletions .prettierrc.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
{
"bracketSpacing": true,
"endOfLine": "auto",
"trailingComma": "none",
"tabWidth": 4,
"printWidth": 120,
"semi": true,
"singleQuote": true
}
"singleQuote": true,
"tabWidth": 4,
"trailingComma": "es5",
"useTabs": true
}
5 changes: 5 additions & 0 deletions .snyk
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
exclude:
global:
- gulp/**
- pipelines/**
- docs/**
9 changes: 9 additions & 0 deletions .stylelintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
dist
dependencies
node_modules
src/static/**

*.css

# don't lint settings
*.snyk
19 changes: 19 additions & 0 deletions .stylelintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"extends": "stylelint-config-prettier",
"plugins": [
"stylelint-order"
],
"rules": {
"order/order": [
[
"dollar-variables",
"at-rules",
"declarations",
"rules",
"custom-properties"
]
],
"order/properties-alphabetical-order": true,
"max-line-length": 170
}
}
6 changes: 5 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,9 @@
},
"[jsonc]": {
"editor.defaultFormatter": "vscode.json-language-features"
},
"sonarlint.connectedMode.project": {
"connectionId": "outsystems",
"projectKey": "OutSystems_outsystems-datagrid-reactive"
}
}
}
1 change: 0 additions & 1 deletion docs/.nojekyll

This file was deleted.

29 changes: 0 additions & 29 deletions docs/assets/highlight.css

This file was deleted.

Loading

0 comments on commit fd6f0ac

Please sign in to comment.