Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROU-10908: Align DataGrid cells vertically to the center #443

Merged
merged 1 commit into from
Jan 23, 2025
Merged

ROU-10908: Align DataGrid cells vertically to the center #443

merged 1 commit into from
Jan 23, 2025

Conversation

OS-pedrolourenco
Copy link
Contributor

This PR is for fixing the align of the content in the cells.

What was happening

  • The visual experience of editing DataGrid cells was undesirable.

What was done

  • All DataGrid cells are now vertically aligned to the center, including when being edited.

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@OS-pedrolourenco OS-pedrolourenco requested a review from a team as a code owner January 22, 2025 13:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OS-pedrolourenco OS-pedrolourenco merged commit ae66304 into dev Jan 23, 2025
14 checks passed
@OS-pedrolourenco OS-pedrolourenco deleted the ROU-10908-2nd-iteration branch January 23, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OS-giulianasilva OS-giulianasilva OS-giulianasilva approved these changes

@joselrio joselrio Awaiting requested review from joselrio

@rugoncalves rugoncalves Awaiting requested review from rugoncalves

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OS-pedrolourenco @OS-giulianasilva