Show progress in austin2speedscope #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't tell you how far through you are but at least you can see that progress is occurring when loading and also can see which of the 2 stages it is currently in.
It wasn't working outside of `main` because the `austin2speedscope` entrypoint directly calls `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Show progress (rather than nothing) during
austin2speedscopeas it can take a long time. As discussed here #31Alternate Designs
Possible alternative here which may be good longer term, though right now I'm afraid I don't have time to dedicate to it.
Regressions
Hopefully none - only the CLI output is affected.
Verification Process
This has been tested on windows & linux with large austin traces and works as I would expect.