Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexibility in process creation #261

Merged
merged 3 commits into from
Feb 19, 2024
Merged

More flexibility in process creation #261

merged 3 commits into from
Feb 19, 2024

Conversation

PooruTorie
Copy link
Contributor

My project needs the flexebility to run docker inside of wsl for that i run docker as wsl docker compose ...
Now this is possible by running for example:

compose.upAll({
   executable: {
      executablePath: "wsl",
      options: ["docker"]
   }
})

PooruTorie and others added 3 commits February 19, 2024 17:21
Add Executable Options to DockerComposeOptions
Add Executable Options to DockerComposeOptions for v1
@AlexZeitler
Copy link
Contributor

@PooruTorie thanks for your contribution. Would you mind adding a small test for verification?

@PooruTorie
Copy link
Contributor Author

Hi,

how should this option be tested
before the changes there was one string to point to the programm that had no test the only change is the executable options that are between the process path and the docker args to make it available to the user to change the process

@AlexZeitler AlexZeitler merged commit 74c7c7b into PDMLab:master Feb 19, 2024
3 checks passed
@AlexZeitler
Copy link
Contributor

@PooruTorie thanks - 📦 0.24.5 has been published on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants