Ruleset::expandRulesetReference(): add tests #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the code coverage report, nearly all those lines are covered via some pre-existing tests, most likely in the |
5 tasks
fredden
approved these changes
Feb 13, 2025
fredden
approved these changes
Feb 13, 2025
|
Thanks for reviewing @fredden ! I'll squash that last commit into the commit it belongs to and will merge once the build has passed again. |
Co-authored-by: Dan Wallis <[email protected]>
Note: test coverage for the `Ruleset::expandRulesetReference()` method will still not be 100% even after the addition of these tests.
* There are some conditions which are specific to running PHPCS via a PHAR file. At this time, the tests are not run with a PHAR file, which means these lines cannot be covered via the tests.
* As for the other uncovered lines/branches: my fantasy ran out and I couldn't come up with a situation which would trigger that code.
Code archaeology (`git blame`) to find out why the code was introduced unfortunately didn't help.
This may indicate the code is redundant and can be removed, but this is not certain at this time and leaving the code in place is not harming anyone for now.
If over time, nobody can come up with a real life situation which would allow us to test those lines, it could be considered to remove them in a future major release to see what breaks....
jrfnl
force-pushed
the
feature/ruleset-expandrulesetreference-add-tests
branch
from
dfdcab2 to
ef411ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ruleset::expandRulesetReference(): test handling "homepath" references
Ruleset::expandRulesetReference(): test handling "Internal" references
Ruleset::expandRulesetReference(): add miscellaneous tests
Note: test coverage for the
Ruleset::expandRulesetReference()method will still not be 100% even after the addition of these tests.Code archaeology (
git blame) to find out why the code was introduced unfortunately didn't help.This may indicate the code is redundant and can be removed, but this is not certain at this time and leaving the code in place is not harming anyone for now.
If over time, nobody can come up with a real life situation which would allow us to test those lines, it could be considered to remove them in a future major release to see what breaks....
Suggested changelog entry
N/A
Related issues/external references
This PR is part of a series of PRs expanding the tests for the
Rulesetclass.