Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ignoredErrors when Not Applicable #4377

Merged
merged 4 commits into from
Feb 23, 2025
Merged

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Feb 20, 2025

Fix #4375. Do not set ignoredErrors when using readDataOnly, nor when the cell to which it applies doesn't exist.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Fix PHPOffice#4375. Do not set ignoredErrors when using readDataOnly, not when the cell to which it applies doesn't exist.
@oleibman oleibman enabled auto-merge February 23, 2025 20:28
@oleibman oleibman added this pull request to the merge queue Feb 23, 2025
Merged via the queue into PHPOffice:master with commit 8c86caa Feb 23, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ignoredErrors causing memory exhaustion
1 participant