Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix/#332] 클래스 개설 후 조타이 초기화 #334

Merged
merged 1 commit into from
Sep 28, 2024
Merged

[Fix/#332] 클래스 개설 후 조타이 초기화 #334

merged 1 commit into from
Sep 28, 2024

Conversation

thisishwarang
Copy link
Contributor

📌 관련 이슈번호

체크리스트

  • 🎋 base 브랜치를 develop 브랜치로 설정했나요?
  • 🖌️ PR 제목은 형식에 맞게 잘 작성했나요?
  • 🏗️ 빌드는 성공했나요? (yarn build)
  • 🧹 불필요한 코드는 제거했나요? e.g. console.log
  • 🙇‍♂️ 리뷰어를 지정했나요?
  • 🏷️ 라벨은 등록했나요?

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. 조타이 atom 초기화
    • 클래스 개설 후 조타이를 초기화 시켜서 이전페이지로 돌아가면 값을 불러오지 못하게 막습니다.

📢 To Reviewers

📸 스크린샷 or 실행영상

@thisishwarang thisishwarang added 🐞 Fix 버그 수정 🥵 화랑 달아오르고마 labels Sep 26, 2024
@thisishwarang thisishwarang self-assigned this Sep 26, 2024
ExceptAnyone
ExceptAnyone reviewed Sep 26, 2024
View reviewed changes
src/pages/class/hooks/useClassPostInputChange.ts
dayOfWeek: '',
startTime: '',
endTime: '',
maxGuest: 7,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxGuest는 default가 7인가요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 맞습니다!

chaeneey
chaeneey approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@chaeneey chaeneey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨숩니당 ~~

@ExceptAnyone ExceptAnyone merged commit b0728d3 into develop Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeneey chaeneey chaeneey approved these changes

@ExceptAnyone ExceptAnyone ExceptAnyone approved these changes

@gudusol gudusol Awaiting requested review from gudusol

Assignees

@thisishwarang thisishwarang

Labels
🐞 Fix 버그 수정 🥵 화랑 달아오르고마
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisishwarang @ExceptAnyone @chaeneey