SL-835 add link to O3 patient chart in ward app patient workspace #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseaton
reviewed
Jan 8, 2025
| @@ -48,17 +49,34 @@ const O2PregnancyInfantProgramDashboard: React.FC<{ patientUuid: string }> = ({ | |||
| '.infant\\.dashboard\\.indicator a', | |||
| ]; | |||
|
|
|||
| const o2PatientChartLink = ( | |||
| <div className={styles.patientChartLinkContainer}> | |||
| <a href={`/openmrs/coreapps/clinicianfacing/patient.page?patientId=${patientUuid}`}>Full patient chart</a> | |||
There was a problem hiding this comment.
The /openmrs really can't be hard-coded in, I'm pretty sure this came up in a prior PR and not sure if we addressed it there or let it go, but this needs to be based on the window.openmrsBase.
Additionally, we should follow best practices and have the display text using the translation utility.
There was a problem hiding this comment.
Right... forgot about that. I'll fix.
mseaton
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Related Issue