로그인 포매팅 버그 수정 + AuthService 리팩토링 #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteHyun
added
🐛 bug
soobin-k
approved these changes
Apr 24, 2023
| UserManager.shared.updatePLUBToken(accessToken: accessToken, refreshToken: refreshToken) | ||
|
|
||
| // == Logging == | ||
| Log.notice("accessToken: \(accessToken)") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
🌱 작업한 내용
yyyyMMdd로 내려보내야하는 걸yyyy-MM-dd형식으로 로그인 요청을 보내고 있었습니다. 서버팀에서yyyyMMdd로 내려줘야한다고 전달받았고 이를 수정했습니다.sendRequest를 전부sendObservableRequest로 리팩토링 완료했습니다. 이에 맞게 기존 코드도 리팩토링하였고, 로깅 코드도 추가하였습니다.📮 관련 이슈