Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] 홈, 검색, 모집 커서페이징 로직 수정 #394

Merged
merged 9 commits into from
May 28, 2023
Merged

[CHORE] 홈, 검색, 모집 커서페이징 로직 수정 #394

merged 9 commits into from
May 28, 2023

Conversation

dlrjswns
Copy link
Contributor

📌 PR 요약

🌱 작업한 내용

  • 홈 추천조회, 검색에 따른 모집글조회, 모집글에 대한 조회 총 3 화면에 따른 커서페이징 작업을 수정하였습니다.

🌱 PR 포인트

  • 제가 포스트맨보면서 하나하나 확인해서 문제가 없다고 판단하긴했는데 혹여 로직에 개선사항이 필요하다 생각되시면 말씀해주세요 !!

📸 스크린샷

홈 추천 페이징
https://github.com/PLUB2022/PLUB-iOS/assets/39263235/3e9e5be8-4a85-490b-b3cc-30beacad49cc
모집글 페이징
https://github.com/PLUB2022/PLUB-iOS/assets/39263235/564d857c-f1ac-4521-9505-a8b78e1dfb12
검색 결과 페이징
https://github.com/PLUB2022/PLUB-iOS/assets/39263235/c38c2fea-ecc0-4b81-8550-6026b7aafd79

📮 관련 이슈

dlrjswns added 9 commits May 27, 2023 23:43
@dlrjswns
[CHORE] 페이징작업을 위한 프로퍼티 변경
53616d5
@dlrjswns
[DEL] 불필요한 파일 삭제
6db6fb4 
PaginatedResponse를 이용함으로써 해당 응답모델이 불필요해짐에 따라 삭제
@dlrjswns
[CHORE] 모집검색을 위한 서비스 sendObservableRequest로 코드 수정
b1f8a53
@dlrjswns
[ADD] SearchParameter를 위한 toEng 프로퍼티 추가
df405ef
@dlrjswns
[FEAT] 홈 추천모집글 커서페이징을 위한 기능 추가
ce1d885
@dlrjswns
[REFACTOR] 뷰모델 코드 컨벤션에 맞춰 코드를 리팩토링 및 커서페이징 기능 추가
a57f3ef
@dlrjswns
[FEAT] 상태초기화에 대한 기능연동
238e8ea 
키워드, 분류, 타입이 변경될때만 상태값 초기화를 해주기위해 clearStatus함수를 이용합니다
@dlrjswns
[FEAT] 모집글조회에 따른 커서페이징 기능 추가
06ead88
@dlrjswns
[DEL] 테스트코드 삭제
1b1bc51
@dlrjswns dlrjswns added 🐛 bug Something isn't working 😎 Enhancement New feature or request 🏠 Home D+1 PR올린 다음날 까지는 리뷰 부탁드립니다 🥳MainPage labels May 27, 2023
@dlrjswns dlrjswns requested review from WhiteHyun and soobin-k May 27, 2023 15:08
@dlrjswns dlrjswns self-assigned this May 27, 2023
soobin-k
soobin-k approved these changes May 28, 2023
View reviewed changes
Copy link
Contributor

@soobin-k soobin-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨습니다 건준님!

@dlrjswns dlrjswns merged commit cd7c897 into develop May 28, 2023
@dlrjswns dlrjswns deleted the chore/Paging-393/Cursor branch May 28, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soobin-k soobin-k soobin-k approved these changes

@WhiteHyun WhiteHyun Awaiting requested review from WhiteHyun

Assignees

@dlrjswns dlrjswns

Labels
🐛 bug Something isn't working D+1 PR올린 다음날 까지는 리뷰 부탁드립니다 😎 Enhancement New feature or request 🏠 Home 🥳MainPage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlrjswns @soobin-k