Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump to sf7 and php83 #1150

Merged
merged 1 commit into from
Jan 5, 2024
Merged

feat: bump to sf7 and php83 #1150

merged 1 commit into from
Jan 5, 2024

Conversation

JellyBellyDev
Copy link
Member

@JellyBellyDev JellyBellyDev commented Jan 4, 2024 •
edited
Loading

  • bump symfony 7
  • bump php 8.3

garak
garak requested changes Jan 4, 2024
View reviewed changes
Copy link
Member

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why not PHP 8.3?

@JellyBellyDev
Copy link
Member Author

but why not PHP 8.3?

it is not too early? :)

@garak
Copy link
Member

garak commented Jan 4, 2024

but why not PHP 8.3?

it is not too early? :)

Is it? I already migrated all of my projects, it's been six weeks since it's out!

@JellyBellyDev JellyBellyDev force-pushed the feat/bump-sf7-and-php82 branch from 7243b95 to 895a37b Compare January 4, 2024 15:00
@JellyBellyDev JellyBellyDev changed the title feat: bump to sf7 and php82 feat: bump to sf7 and php83 Jan 4, 2024
@JellyBellyDev JellyBellyDev force-pushed the feat/bump-sf7-and-php82 branch 3 times, most recently from 0bf910b to cc5e2e7 Compare January 4, 2024 15:43
@JellyBellyDev
Copy link
Member Author

@garak could you help me fix the tests as I don't have much experience with phpunit 10?

@garak
Copy link
Member

garak commented Jan 4, 2024

My advice is to stay on PHPUnit 9 for now.
Unfortunately, the Symfony PHPUnit bridge doesn't support version 10 yet

@JellyBellyDev JellyBellyDev force-pushed the feat/bump-sf7-and-php82 branch 2 times, most recently from 1d40580 to bd36fa7 Compare January 5, 2024 08:44
@JellyBellyDev JellyBellyDev marked this pull request as ready for review January 5, 2024 08:56
@JellyBellyDev JellyBellyDev requested a review from garak January 5, 2024 08:56
@JellyBellyDev JellyBellyDev force-pushed the feat/bump-sf7-and-php82 branch from bd36fa7 to 0cdab75 Compare January 5, 2024 09:02
@JellyBellyDev JellyBellyDev force-pushed the feat/bump-sf7-and-php82 branch from 0cdab75 to 9c36309 Compare January 5, 2024 09:05
@JellyBellyDev JellyBellyDev merged commit eaa1c18 into master Jan 5, 2024
3 checks passed
@JellyBellyDev JellyBellyDev deleted the feat/bump-sf7-and-php82 branch January 5, 2024 10:51
This was referenced Jan 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garak garak garak approved these changes

@fabiocicerchia fabiocicerchia Awaiting requested review from fabiocicerchia

@AlessandroMinoccheri AlessandroMinoccheri Awaiting requested review from AlessandroMinoccheri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JellyBellyDev @garak