Move to per i2c bus mutex in Qurt i2c driver #23531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katzfey
force-pushed
the
pr-qurt_i2c_mutex_per_bus
branch
from
d13386c to
20a218c
Compare
dagar
reviewed
Feb 18, 2025
src/lib/drivers/device/qurt/I2C.hpp
Outdated
| @@ -124,10 +124,18 @@ class __EXPORT I2C : public CDev | |||
| private: | |||
| uint32_t _frequency{0}; | |||
| int _i2c_fd{-1}; | |||
| pthread_mutex_t *_mutex; | |||
There was a problem hiding this comment.
Suggested change
| pthread_mutex_t *_mutex; | |
| pthread_mutex_t *_mutex{nullptr}; |
…o one for each bus.
katzfey
force-pushed
the
pr-qurt_i2c_mutex_per_bus
branch
from
20a218c to
000f7f2
Compare
dagar
approved these changes
Feb 19, 2025
JoelJ18
pushed a commit
to microstrain-robotics/PX4-Autopilot
that referenced
this pull request
Feb 24, 2025
…utex to one for each bus. (PX4#23531)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The i2c driver for Qurt uses a single mutex for all buses. If a single bus has a long timeout it can hold up activity on the other buses needlessly. This PR changes the single mutex into a mutex for each bus to avoid that issue.