-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mavsdk_tests: add multicopter alt hold test #24396
base: main
Are you sure you want to change the base?
mavsdk_tests: add multicopter alt hold test #24396
Conversation
37eee44
to
2e18156
Compare
If I increase the sleep time from 30 seconds to say 2 mins I bet we'd see failures at 2m. In gz sim with x500 after a few minutes of hovering I see up to 2.5m error. |
This PR also fixes log upload on failed tests. However the logs can be pretty big, so maybe we want to reduce SDLOG_PROFILE for SITL tests. 135MB log file from the latest failure |
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
Can you please update the models on this branch so the tests pass? |
f02e02a
to
4e4f35b
Compare
4e4f35b
to
a46d254
Compare
a46d254
to
49f58c7
Compare
Looks removing the random walk from the gazebo-classic IMU fixes all of the mavsdk-sitl tests. So indeed the altitude issue was likely causing the failures. Shall we remove the random walk from all of the airframes now? @bresch maybe an explanation would be helpful on how things have changed, @Jaeyoung-Lim had some concerns about why the sim worked well before |
CI SITL test for multicopter takeoff and hold. This is for testing EKF height estimation issues.