fix failsafe behavior after RC loss and mode switch #24424
Draft
+0
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Scenario:
- drone in altitude mode and switches to RTL failsafe after RC loss
- while in RTL, the user selects "position mode", the vehicle command gets rejected because of missing manual mode
- the vehicle switches to altitude mode, despite not having any manual control input!
Solution
I removed the
_had_mode_change = true;
which always indicated that the "intended mode" has change even when it got rejected.Now the scenario would look like:
- drone in altitude mode and switches to RTL failsafe after RC loss
- while in RTL, the user selects "position mode", the vehicle command gets rejected because of missing manual mode
- the vehicle stays in RTL
- RC connects again, vehicle stays in RTL until mode gets switched again or switches to position mode if user gives stick input (depending on COM_RC_STICK_OV)