Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zero bug of case18: paddle.logsumexp #51034

Merged
merged 4 commits into from
Mar 1, 2023

Conversation

chenxiao120660
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Describe

paddle.logsumexp在如下代码会报错:
import paddle import numpy as np array = np.array([], dtype=np.float32) x = paddle.to_tensor(np.reshape(array, [0] * 3), dtype='float32') paddle.logsumexp(x, axis=0)
原因:问题在于没有对输入进行检查, 输入的size不能为0
解决方案: 在c++代码中添加检查,并增加相应的单测代码.
#49927
#49919

@paddle-bot
Copy link

paddle-bot bot commented Feb 28, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Feb 28, 2023

CLA assistant check
All committers have signed the CLA.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Feb 28, 2023
@chenxiao120660 chenxiao120660 changed the title fix bug of logsumexp fix bug of logsumexp of case18: paddle.logsumexp Mar 1, 2023
@chenxiao120660 chenxiao120660 changed the title fix bug of logsumexp of case18: paddle.logsumexp fix zero bug of case18: paddle.logsumexp Mar 1, 2023
@luotao1
Copy link
Contributor

luotao1 commented Mar 1, 2023

@chenxiao120660 可以报名参加下黑客松赛题:#50630 (comment)

@chenxiao120660
Copy link
Contributor Author

@chenxiao120660 可以报名参加下黑客松赛题:#50630 (comment)

好的,我们已经报名了序号为31的题目

Copy link
Contributor

@veyron95 veyron95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 2f90096 into PaddlePaddle:develop Mar 1, 2023
@luotao1
Copy link
Contributor

luotao1 commented Mar 2, 2023

hi, @chenxiao120660

  • 非常感谢你对飞桨框架的贡献,我们正在运营一个PFCC组织,会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献,详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣,请发送邮件至 [email protected],我们会邀请你加入~

@chenxiao120660
Copy link
Contributor Author

hi, @chenxiao120660

  • 非常感谢你对飞桨框架的贡献,我们正在运营一个PFCC组织,会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献,详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣,请发送邮件至 [email protected],我们会邀请你加入~

好的我已经发送了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants