Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[phi] mv sequence_pool to phi - Step 1 : sequence_pooling_test #52782

Merged
merged 2 commits into from
Apr 12, 2023
Merged

[phi] mv sequence_pool to phi - Step 1 : sequence_pooling_test #52782

merged 2 commits into from
Apr 12, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Apr 11, 2023

PR types

Others

PR changes

Others

Describe

将 sequence_pool 迁移至 phi

相关issues

@paddle-bot
Copy link

paddle-bot bot commented Apr 11, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 11, 2023
This was referenced Apr 11, 2023
Merged
Merged
Closed
@luotao1
Copy link
Contributor

luotao1 commented Apr 11, 2023

请 @tianshuo78520a @zhiqiu 看下单测迁移任务中，是不是遗漏了：paddle/fluid/operators-》 test/cpp/phi？

@tianshuo78520a
Copy link
Collaborator

请 @tianshuo78520a @zhiqiu 看下单测迁移任务中，是不是遗漏了：paddle/fluid/operators-》 test/cpp/phi？

是的，应该将paddle/fluid/operators下的单测，也进行迁移，迁移到test/cpp/phi 目录下，能否帮助一起迁移呢？

@gouzil
Copy link
Member Author

gouzil commented Apr 11, 2023

请 @tianshuo78520a @zhiqiu 看下单测迁移任务中，是不是遗漏了：paddle/fluid/operators-》 test/cpp/phi？

是的，应该将paddle/fluid/operators下的单测，也进行迁移，迁移到test/cpp/phi 目录下，能否帮助一起迁移呢？

行，全部吗

@gouzil
Copy link
Member Author

gouzil commented Apr 11, 2023 •
edited
Loading

请 @tianshuo78520a @zhiqiu 看下单测迁移任务中，是不是遗漏了：paddle/fluid/operators-》 test/cpp/phi？

是的，应该将paddle/fluid/operators下的单测，也进行迁移，迁移到test/cpp/phi 目录下，能否帮助一起迁移呢？

/paddle/fluid/operators/benchmark/op_tester_config.cc
/paddle/fluid/operators/benchmark/op_tester_config.h
/paddle/fluid/operators/benchmark/op_tester.h
/paddle/fluid/operators/benchmark/op_tester.cc
/paddle/fluid/operators/reader/reader_blocking_queue_test.cc
/paddle/fluid/operators/scatter_test.cc
/paddle/fluid/operators/gather_test.cc
/paddle/fluid/operators/prim_ops/prim_op_test.cc
/paddle/fluid/operators/nccl/nccl_op_test.cu.cc
/paddle/fluid/operators/feed_forward_test.cu
/paddle/fluid/operators/copy_cross_scope_test.cc
/paddle/fluid/operators/reduce_ops/check_reduce_rank_test.cu
/paddle/fluid/operators/beam_search_decode_op_test.cc
/paddle/fluid/operators/lite/lite_engine_op_test.cc
/paddle/fluid/operators/save_load_combine_op_test.cc
/paddle/fluid/operators/fused/cudnn_bn_add_relu_test.cc
/paddle/fluid/operators/fused/fused_layernorm_residual_dropout_bias_test.cu
/paddle/fluid/operators/fused/cudnn_norm_conv_test.cc
/paddle/fluid/operators/fused/fused_dropout_act_bias_test.cu
/paddle/fluid/operators/fused/fusion_group_op_test.cc
/paddle/fluid/operators/fused/fused_dropout_test.h
/paddle/fluid/operators/fused/fused_residual_dropout_bias_test.cu
/paddle/fluid/operators/test_common_infer_shape_functions.cc
/paddle/fluid/operators/cinn/cinn_instruction_run_op_test.cc
/paddle/fluid/operators/cinn/test_helper.h
/paddle/fluid/operators/cinn/cinn_launch_context_test.cc
/paddle/fluid/operators/cinn/cinn_launch_op_test.cc
/paddle/fluid/operators/share_buffer_op_test.cc
/paddle/fluid/operators/test_leaky_relu_grad_grad_functor.cc
/paddle/fluid/operators/beam_search_decode_op_xpu_test.cc
/paddle/fluid/operators/dlnne/dlnne_engine_op_test.cc
/paddle/fluid/operators/math/vol2col_test.cc
/paddle/fluid/operators/math/im2col_test.cc
/paddle/fluid/operators/math/beam_search_test.cc
/paddle/fluid/operators/math/selected_rows_functor_test.cc
/paddle/fluid/operators/math/selected_rows_functor_test.cu.cc
/paddle/fluid/operators/math/concat_test.cc
/paddle/fluid/operators/generator/tests_utils.py
/paddle/fluid/operators/elementwise/test_elementwise_op_grad_grad.h
/paddle/fluid/operators/elementwise/test_elementwise_div_grad_grad.cc
/paddle/fluid/operators/elementwise/test_elementwise_add_grad_grad.cc
/paddle/fluid/operators/elementwise/test_elementwise_add_op_inplace.cc
/paddle/fluid/operators/test_leaky_relu_grad_grad_functor.h
/paddle/fluid/operators/assign_op_test.cc
/paddle/fluid/operators/tensorrt/tensorrt_engine_op_test.cc
/paddle/fluid/operators/op_debug_string_test.cc
/paddle/fluid/operators/save_load_op_test.cc
/paddle/fluid/operators/mkldnn/test_mkldnn_caching.cc
/paddle/fluid/operators/mkldnn/test_mkldnn_op_inplace.cc
/paddle/fluid/operators/mkldnn/caching_tests.cmake
/paddle/fluid/operators/mkldnn/nhwc_op_tests.cmake
/paddle/fluid/operators/mkldnn/test_mkldnn_op_nhwc.cc
/paddle/fluid/operators/mkldnn/inplace_op_tests.cmake
/paddle/fluid/operators/test_leaky_relu_grad_grad_functor.cu
/paddle/fluid/operators/detection/mask_util_test.cc
/paddle/fluid/operators/controlflow/conditional_block_op_test.cc
/paddle/fluid/operators/pscore/switch_server_test.cc
/paddle/fluid/operators/pscore/heter_cloud_comm_cpu_test.cc
/paddle/fluid/operators/pscore/send_and_recv_op_gpu_test.cc
/paddle/fluid/operators/pscore/heter_listen_and_server_test.cc
/paddle/fluid/operators/pscore/send_and_recv_op_cpu_test.cc
/paddle/fluid/operators/pscore/heter_server_test.cc
/paddle/fluid/operators/dropout_op_test.cc

@tianshuo78520a
Copy link
Collaborator

请 @tianshuo78520a @zhiqiu 看下单测迁移任务中，是不是遗漏了：paddle/fluid/operators-》 test/cpp/phi？

是的，应该将paddle/fluid/operators下的单测，也进行迁移，迁移到test/cpp/phi 目录下，能否帮助一起迁移呢？

行，全部吗

如果可以的话，一起迁移最好，非常感谢

@luotao1
Copy link
Contributor

luotao1 commented Apr 12, 2023

@gouzil 可以先把这个PR合了，剩下的等 @tianshuo78520a 把新路径写出来后再进行迁移

@gouzil
Copy link
Member Author

gouzil commented Apr 12, 2023

@gouzil 可以先把这个PR合了，剩下的等 @tianshuo78520a 把新路径写出来后再进行迁移

好的👌

zhiqiu
zhiqiu approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit c376a94 into PaddlePaddle:develop Apr 12, 2023
@gouzil gouzil deleted the mv_sequence_pooling_test branch April 13, 2023 15:37
@gouzil
Copy link
Member Author

gouzil commented Apr 26, 2023 •
edited
Loading

@tianshuo78520a 大佬看一下如果可以的话我就开始迁了

旧位置 新位置 pr
/paddle/fluid/operators/benchmark/op_tester_config.cc /test/cpp/fluid/benchmark/op_tester_config.cc #53426
/paddle/fluid/operators/benchmark/op_tester_config.h /test/cpp/fluid/benchmark/op_tester_config.h #53426
/paddle/fluid/operators/benchmark/op_tester.h /test/cpp/fluid/benchmark/op_tester.h #53426
/paddle/fluid/operators/benchmark/op_tester.cc /test/cpp/fluid/benchmark/op_tester.cc #53426
/paddle/fluid/operators/reader/reader_blocking_queue_test.cc /test/cpp/fluid/reader/reader_blocking_queue_test.cc #53429
/paddle/fluid/operators/scatter_test.cc /test/cpp/fluid/scatter_test.cc #53472
/paddle/fluid/operators/gather_test.cc /test/cpp/fluid/gather_test.cc #53472
/paddle/fluid/operators/prim_ops/prim_op_test.cc /test/cpp/fluid/prim_ops/prim_op_test.cc #53429
/paddle/fluid/operators/nccl/nccl_op_test.cu.cc /test/cpp/fluid/nccl/nccl_op_test.cu.cc #53429
/paddle/fluid/operators/feed_forward_test.cu /test/cpp/fluid/feed_forward_test.cu #53472
/paddle/fluid/operators/copy_cross_scope_test.cc /test/cpp/fluid/copy_cross_scope_test.cc #53472
/paddle/fluid/operators/reduce_ops/check_reduce_rank_test.cu /test/cpp/fluid/reduce_ops/check_reduce_rank_test.cu #53429
/paddle/fluid/operators/beam_search_decode_op_test.cc /test/cpp/fluid/beam_search_decode_op_test.cc #53472
/paddle/fluid/operators/lite/lite_engine_op_test.cc /test/cpp/fluid/lite/lite_engine_op_test.cc #53429
/paddle/fluid/operators/save_load_combine_op_test.cc /test/cpp/fluid/save_load_combine_op_test.cc #53472
/paddle/fluid/operators/fused/cudnn_bn_add_relu_test.cc /test/cpp/fluid/fused/cudnn_bn_add_relu_test.cc #53434
/paddle/fluid/operators/fused/fused_layernorm_residual_dropout_bias_test.cu /test/cpp/fluid/fused/fused_layernorm_residual_dropout_bias_test.cu #53434
/paddle/fluid/operators/fused/cudnn_norm_conv_test.cc /test/cpp/fluid/fused/cudnn_norm_conv_test.cc #53434
/paddle/fluid/operators/fused/fused_dropout_act_bias_test.cu /test/cpp/fluid/fused/fused_dropout_act_bias_test.cu #53434
/paddle/fluid/operators/fused/fusion_group_op_test.cc /test/cpp/fluid/fused/fusion_group_op_test.cc #53434
/paddle/fluid/operators/fused/fused_dropout_test.h /test/cpp/fluid/fused/fused_dropout_test.h #53434
/paddle/fluid/operators/fused/fused_residual_dropout_bias_test.cu /test/cpp/fluid/fused/fused_residual_dropout_bias_test.cu #53434
/paddle/fluid/operators/test_common_infer_shape_functions.cc /test/cpp/fluid/test_common_infer_shape_functions.cc #53472
/paddle/fluid/operators/cinn/cinn_instruction_run_op_test.cc /test/cpp/fluid/cinn/cinn_instruction_run_op_test.cc #53443
/paddle/fluid/operators/cinn/test_helper.h /test/cpp/fluid/cinn/test_helper.h #53443
/paddle/fluid/operators/cinn/cinn_launch_context_test.cc /test/cpp/fluid/cinn/cinn_launch_context_test.cc #53443
/paddle/fluid/operators/cinn/cinn_launch_op_test.cc /test/cpp/fluid/cinn/cinn_launch_op_test.cc #53443
/paddle/fluid/operators/share_buffer_op_test.cc /test/cpp/fluid/share_buffer_op_test.cc #53472
/paddle/fluid/operators/test_leaky_relu_grad_grad_functor.cc /test/cpp/fluid/test_leaky_relu_grad_grad_functor.cc #53472
/paddle/fluid/operators/beam_search_decode_op_xpu_test.cc /test/cpp/fluid/beam_search_decode_op_xpu_test.cc #53472
/paddle/fluid/operators/dlnne/dlnne_engine_op_test.cc /test/cpp/fluid/dlnne/dlnne_engine_op_test.cc #53470
/paddle/fluid/operators/math/vol2col_test.cc /test/cpp/fluid/math/vol2col_test.cc #53446
/paddle/fluid/operators/math/im2col_test.cc /test/cpp/fluid/math/im2col_test.cc #53446
/paddle/fluid/operators/math/beam_search_test.cc /test/cpp/fluid/math/beam_search_test.cc #53446
/paddle/fluid/operators/math/selected_rows_functor_test.cc /test/cpp/fluid/math/selected_rows_functor_test.cc #53446
/paddle/fluid/operators/math/selected_rows_functor_test.cu.cc /test/cpp/fluid/math/selected_rows_functor_test.cu.cc #53446
/paddle/fluid/operators/math/concat_test.cc /test/cpp/fluid/math/concat_test.cc #53446
/paddle/fluid/operators/elementwise/test_elementwise_op_grad_grad.h /test/cpp/fluid/elementwise/test_elementwise_op_grad_grad.h #53448
/paddle/fluid/operators/elementwise/test_elementwise_div_grad_grad.cc /test/cpp/fluid/elementwise/test_elementwise_div_grad_grad.cc #53448
/paddle/fluid/operators/elementwise/test_elementwise_add_grad_grad.cc /test/cpp/fluid/elementwise/test_elementwise_add_grad_grad.cc #53448
/paddle/fluid/operators/elementwise/test_elementwise_add_op_inplace.cc /test/cpp/fluid/elementwise/test_elementwise_add_op_inplace.cc #53448
/paddle/fluid/operators/test_leaky_relu_grad_grad_functor.h /test/cpp/fluid/test_leaky_relu_grad_grad_functor.h #53472
/paddle/fluid/operators/assign_op_test.cc /test/cpp/fluid/assign_op_test.cc #53472
/paddle/fluid/operators/tensorrt/tensorrt_engine_op_test.cc /test/cpp/fluid/tensorrt/tensorrt_engine_op_test.cc #53470
/paddle/fluid/operators/op_debug_string_test.cc /test/cpp/fluid/op_debug_string_test.cc #53472
/paddle/fluid/operators/save_load_op_test.cc /test/cpp/fluid/save_load_op_test.cc #53472
/paddle/fluid/operators/mkldnn/test_mkldnn_caching.cc /test/cpp/fluid/mkldnn/test_mkldnn_caching.cc #53458
/paddle/fluid/operators/mkldnn/test_mkldnn_op_inplace.cc /test/cpp/fluid/mkldnn/test_mkldnn_op_inplace.cc #53458
/paddle/fluid/operators/mkldnn/caching_tests.cmake /test/cpp/fluid/mkldnn/caching_tests.cmake #53458
/paddle/fluid/operators/mkldnn/nhwc_op_tests.cmake /test/cpp/fluid/mkldnn/nhwc_op_tests.cmake #53458
/paddle/fluid/operators/mkldnn/test_mkldnn_op_nhwc.cc /test/cpp/fluid/mkldnn/test_mkldnn_op_nhwc.cc #53458
/paddle/fluid/operators/mkldnn/inplace_op_tests.cmake /test/cpp/fluid/mkldnn/inplace_op_tests.cmake #53458
/paddle/fluid/operators/test_leaky_relu_grad_grad_functor.cu /test/cpp/fluid/test_leaky_relu_grad_grad_functor.cu #53472
/paddle/fluid/operators/detection/mask_util_test.cc /test/cpp/fluid/detection/mask_util_test.cc #53470
/paddle/fluid/operators/controlflow/conditional_block_op_test.cc /test/cpp/fluid/controlflow/conditional_block_op_test.cc #53470
/paddle/fluid/operators/pscore/switch_server_test.cc /test/cpp/fluid/pscore/switch_server_test.cc #53460
/paddle/fluid/operators/pscore/heter_cloud_comm_cpu_test.cc /test/cpp/fluid/pscore/heter_cloud_comm_cpu_test.cc #53460
/paddle/fluid/operators/pscore/send_and_recv_op_gpu_test.cc /test/cpp/fluid/pscore/send_and_recv_op_gpu_test.cc #53460
/paddle/fluid/operators/pscore/heter_listen_and_server_test.cc /test/cpp/fluid/pscore/heter_listen_and_server_test.cc #53460
/paddle/fluid/operators/pscore/send_and_recv_op_cpu_test.cc /test/cpp/fluid/pscore/send_and_recv_op_cpu_test.cc #53460
/paddle/fluid/operators/pscore/heter_server_test.cc /test/cpp/fluid/pscore/heter_server_test.cc #53460
/paddle/fluid/operators/dropout_op_test.cc /test/cpp/fluid/dropout_op_test.cc #53472

@tianshuo78520a
Copy link
Collaborator

我感觉不应该放在phi目录下，直接在/test/cpp目录下创建子创建吧。
比如：/paddle/fluid/operators/pscore/heter_server_test.cc -> /test/cpp/pscore/heter_server_test.cc
没有子目录的可以类似python创建一个legacy_test目录？ @zhiqiu 麻烦看下

@gouzil
Copy link
Member Author

gouzil commented Apr 26, 2023

我感觉不应该放在phi目录下，直接在/test/cpp目录下创建子创建吧。 比如：/paddle/fluid/operators/pscore/heter_server_test.cc -> /test/cpp/pscore/heter_server_test.cc 没有子目录的可以类似python创建一个legacy_test目录？ @zhiqiu 麻烦看下

我感觉可以放在/test/cpp/fluid/pscore/heter_server_test.cc下, 但我看好像不在使用fluid了

@zyfncg
Copy link
Contributor

zyfncg commented Apr 27, 2023 •
edited
Loading

image

按这个目录层级看，感觉cpp下面还是需要一个fluid或者operators的目录来放这些单测。fluid/operators里的tests主要都还是在测一些算子的逻辑

另外/paddle/fluid/operators/generator/tests_utils.py这是个代码生成的脚本，不用调整位置

@luotao1
Copy link
Contributor

luotao1 commented Apr 27, 2023

@gouzil 可以按照 #52782 (comment) 进行迁移

@luotao1 luotao1 mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@tianshuo78520a tianshuo78520a tianshuo78520a approved these changes

Assignees

@luotao1 luotao1

@zhiqiu zhiqiu

@tianshuo78520a tianshuo78520a

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gouzil @luotao1 @tianshuo78520a @zyfncg @zhiqiu