Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move fusion_group kernel to phi #53781

Merged
merged 15 commits into from
May 18, 2023
Merged

move fusion_group kernel to phi #53781

merged 15 commits into from
May 18, 2023

Conversation

huangjiyi
Copy link
Member

@huangjiyi huangjiyi commented May 12, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

@paddle-bot
Copy link

paddle-bot bot commented May 12, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels May 12, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 12, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@huangjiyi huangjiyi mentioned this pull request May 15, 2023
Closed
@huangjiyi
Copy link
Member Author

@From00 ，帮忙 Review 一下 ～

From00
From00 reviewed May 16, 2023
View reviewed changes
paddle/phi/kernels/fusion_group_kernel.h Outdated
namespace phi {

template <typename T, typename Context>
void FusionGroupKernel(const Context& dev_ctx,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fused类算子需统一放置在paddle/phi/kernels/fused目录下，代码实现在phi::fusion命名空间中

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done，但是我看 paddle/phi/kernels/fused 下的 kernel 都没有对应的头文件，所以我把头文件给删了

paddle/phi/kernels/gpu/fusion_group_kernel.cu Outdated
phi::FusionGroupKernel,
float,
double,
phi::dtype::float16) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此算子需要迁移infershape，并在infershape中通过outs_dtype属性推导输出类型。
可以在这个PR合入后单独提一个迁移infershape的PR。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get，后续单独提一个 PR

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label May 17, 2023
@huangjiyi
Copy link
Member Author

@From00 ，帮忙 Rerun 一下 PR-CI-CINN ~

@huangjiyi
Copy link
Member Author

@From00 ，帮忙再 Review 一下 ～

From00
From00 approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 26da689 into PaddlePaddle:develop May 18, 2023
@huangjiyi huangjiyi mentioned this pull request May 18, 2023
Merged
@huangjiyi huangjiyi deleted the move_fusion_group branch January 9, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@From00 From00 From00 approved these changes

Assignees

@luotao1 luotao1

@From00 From00

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huangjiyi @From00 @luotao1