This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
Added MacOs Sierra. Fixed bug where El Capitan was detected as Puma. … #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added another Opera identifier
lawnchamp
reviewed
Feb 6, 2017
| { name: 'Mac OS X Puma', group: 'Mac OS', identifier: 'Mac OS X (10([_|\.])1([0-9_\.]*))', versionSeparator: '[_|\.]' }, | ||
| { name: 'Mac OS X Cheetah', group: 'Mac OS', identifier: 'Mac OS X (10([_|\.])0([0-9_\.]*))', versionSeparator: '[_|\.]' }, | ||
| { name: 'iPhone', group: 'iOS', identifier: 'iPhone OS', versionIdentifier: 'OS ([0-9_]*)', versionSeparator: '[_|\.]' }, | ||
| { name: 'Mac OS X Sierra', group: 'Mac OS', identifier: 'Mac OS X (10([_|\.])12\.([0-9_\.]*))', versionSeparator: '[_|\.]' }, |
There was a problem hiding this comment.
Apple did not call their new operating system Mac OS X Sierra so I don't think you should name it this. I understand the desire to maintain consistency but I think since Apple broke their long established convention we should too. Apple is calling it macOS Sierra https://en.wikipedia.org/wiki/MacOS_Sierra
|
I have a similar PR out to add support for Sierra #20 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MacOs Sierra. Fixed bug where El Capitan was detected as Puma. Added another Opera identifier.
I did not minify the file because I do not know what tools are you using to do so.