This repository has been archived by the owner on Mar 27, 2020. It is now read-only.
boring build system stuff #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everything in .idea/ and all .iml files should not be included in git. They are generated by Android Studio when opening a gradle project. They will be different for each person's Android Studio, so if they are in git, it'll be an endless source of git conflicts.
This just makes sure that the downloaded binary matches the official release binary, i.e. has no malware in it. The gradle-wrapper.jar was copied from the open-keychain project, since they know this stuff better than me :) https://github.com/open-keychain/open-keychain/raw/92d2a052f1e660f498294bdb57f1237ae81fc770/gradle/wrapper/gradle-wrapper.jar
This makes sure that the downloaded jars match what the original developer saw. The gradle-witness.jar comes from Signal, since Whisper Systems wrote gradle witness: https://github.com/WhisperSystems/Signal-Android/raw/a9637baddf22bed58c6dba18ee39ffc543a0751e/libs/gradle-witness.jar
This is my collection of hacks to make travis-ci more reliably run the test suite in an emulator. It also updates the SDK tools to the latest version to make sure things are working there.
eighthave
force-pushed
the
dev
branch
2 times, most recently
from
5836fb6 to
f92db01
Compare
|
This has a very minor conflict with #157: the sha256 hashes will have to be updated when merging the second one of these two pull requests (this and #157). That can be done by first removing the |
|
Thanks a ton for this @eighthave. Really appreciate you passing down your best practices! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of the gradle best practices that I've gathered from various projects. I think it'll be useful here too. Each commit message contains more details.