Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full support for UnixDomainSocket #10088

Closed
wants to merge 1 commit into from
Closed

Conversation

Coloryr
Copy link

@Coloryr Coloryr commented Dec 28, 2023

full support for UnixDomainSocketAddress
It must work with this
It change the api, but retained original support
{4E839E59-23CF-4fa3-B0F9-2C75F679304E}
image

server-ip=unix\:/tmp/paperserver.sock
[servers]
# Configure your servers here. Each key represents the server's name, and the value
# represents the IP address of the server to connect to.
lobby = "unix:/tmp/paperserver.sock"

@electronicboy
Copy link
Member

except it doesn't retain original support, it just means that that stuff will blow up, and so, this cannot be merged until a major

also, patches generally should not modify earlier patches

@Owen1212055
Copy link
Member

Seems to dupe ? #9086

@Coloryr
Copy link
Author

Coloryr commented Dec 29, 2023

except it doesn't retain original support, it just means that that stuff will blow up, and so, this cannot be merged until a major

also, patches generally should not modify earlier patches

No, if UDS is not used, the original API is supported
And I need to delete the patch before the modification?

@Coloryr
Copy link
Author

Coloryr commented Dec 29, 2023

Seems to dupe ? #9086

The modified content is the same, but the modification method and API processing are different

@Coloryr Coloryr changed the title full support for UnixDomainSocketAddress full support for UnixDomainSocket Dec 29, 2023
@Coloryr
Copy link
Author

Coloryr commented Dec 29, 2023

My modification is for the group server
and the idea is backend server use UDS transport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants