Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getForwards/SidewaysMovement for players #12140

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Fix getForwards/SidewaysMovement for players #12140

merged 3 commits into from
Feb 18, 2025

Conversation

Warriorrrr
Copy link
Member

Closes #12139

@Warriorrrr Warriorrrr added type: bug Something doesn't work as it was intended to. scope: api labels Feb 17, 2025
@Warriorrrr Warriorrrr requested a review from a team as a code owner February 17, 2025 15:05
lynxplay
lynxplay approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@lynxplay lynxplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved outside of the if branch styling.

@Lulu13022002
Copy link
Contributor

Maybe getUpwardsMovement could be overriden too for consistency even if the javadocs say otherwise.
Can you also format the javadocs to make proper list (or at least newlines inbetween) currently the list is flattened.

@lynxplay
Copy link
Contributor

Don't think we need to go further than sidewards/forward.
The new way of this is going to be the player input that is exposed.
We can obsolete them on Player in a follow up PR if we want but yea.

@lynxplay lynxplay merged commit 09f1f88 into PaperMC:main Feb 18, 2025
3 checks passed
@Warriorrrr Warriorrrr deleted the fix/player-forwards-sideways-movement branch February 18, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machine-Maker Machine-Maker Machine-Maker approved these changes

@lynxplay lynxplay lynxplay approved these changes

Assignees
No one assigned
Labels
scope: api type: bug Something doesn't work as it was intended to.
Projects
Paper PR Queue
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Player#getForwardsMovement/getSidewaysMovement is not updated
4 participants
@Warriorrrr @Lulu13022002 @lynxplay @Machine-Maker