Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update adventure #1163

Closed
wants to merge 2 commits into from
Closed

Conversation

RealBauHD
Copy link
Contributor

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@RealBauHD
Copy link
Contributor Author

The ByteBuf Holder in 'Registry Sync' can now be replaced by nameless Compound reading, right?

@RealBauHD
Copy link
Contributor Author

I wait for some feedback regarding which way I should go with resource packs.

@EpicPlayerA10
Copy link
Contributor

EpicPlayerA10 commented Jan 17, 2024

I wait for some feedback regarding which way I should go with resource packs.

At first seems good to me. I was thinking of moving the whole resourcepack logic to some kind of ResourcepackManager because the code, that is handling resourcepacks, grows very quickly.

@electronicboy
Copy link
Member

I believe that theres been a few attempts to try to deal with this API, I believe adrian got the furtherst in terms of actually implementing stuff, but, theres a lot of headaches to deal with, i.e. this PR generally seems to forget the behavioral differences between modern versions and latest which need to be looked into properly and handled as such

@RealBauHD RealBauHD closed this Jan 17, 2024
@RealBauHD RealBauHD deleted the adventure branch December 22, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants