Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): auto updates #842

Open
wants to merge 5 commits into
base: dev/3.0.0
Choose a base branch
from

Conversation

AV3RG
Copy link

@AV3RG AV3RG commented Aug 16, 2022

closes #809

TODO:

  • Rollback in case of a failure while updating
  • Let the users enable/disable auto updates using config or startup flags
  • Test changes

@AV3RG AV3RG force-pushed the feat/update-plugins branch from 3519d82 to ea7d5c5 Compare August 16, 2022 13:40
@AV3RG AV3RG force-pushed the feat/update-plugins branch from 0cf2ef2 to 1ef0c01 Compare December 9, 2022 11:50
@AV3RG AV3RG marked this pull request as ready for review December 9, 2022 12:16
@AV3RG AV3RG force-pushed the feat/update-plugins branch from 1ef0c01 to 708b634 Compare December 10, 2022 08:31
@Noorquacker
Copy link

This would be a great feature :)

@Joo200
Copy link
Contributor

Joo200 commented Mar 26, 2023

Is there any progress here?

The Merge conflicts can be resolved easily, i rebased the branch and fixed the checkstyles in this branch:
https://github.com/Joo200/Velocity/tree/feat/update-plugins

@AV3RG AV3RG force-pushed the feat/update-plugins branch from 708b634 to f23b66d Compare March 28, 2023 16:49
@AV3RG
Copy link
Author

AV3RG commented Mar 28, 2023

Not too sure how I did not get a notification for pending conflicts in this pull request and how I passed the check-style last time

@AV3RG AV3RG force-pushed the feat/update-plugins branch from f23b66d to d192d36 Compare June 13, 2023 12:43
@Noorquacker
Copy link

Hiiii,
Has any reviewer had a chance to look at the official code yet? It's been nearly a year in the making, but it's better late than never

@Joo200
Copy link
Contributor

Joo200 commented Jul 12, 2023

I'm using this on my server and it works fine. The implementation and the code looks fine.

I'm not a reviewer here so I can't hit the approve button in github. But imo it should be ready to be merged.

@Noorquacker
Copy link

I'm gonna do it:
@4drian3d @StealWonders can we get a review 👉🏾👈🏾

@Noorquacker
Copy link

Erm
Any update?

@AV3RG AV3RG force-pushed the feat/update-plugins branch from d192d36 to d726583 Compare December 16, 2023 07:04
@AV3RG
Copy link
Author

AV3RG commented Dec 16, 2023

Kind of conflicted on the usage of List instead of HashMap for loaded candidates. Using HashMap would help in matching of plugin ids when trying to search for the possible updates here
PluginDescription possibleMatch = found.get(updatedDescription.getId());

Do we wanna use streams here or should we revert back to HashMap

@4drian3d 4drian3d added the type: feature New feature or request label Jan 19, 2024
@AV3RG AV3RG requested a review from 4drian3d February 25, 2024 18:31
@4drian3d
Copy link
Contributor

You have conflicts to resolve before requesting another review
image

@carlodrift
Copy link

Updated from upstream, resolved conflicts, and tested the changes—everything seems to be working fine: AV3RG#1
Should I create a new PR?

Resolve conflicts: Feat/update plugins
@AV3RG
Copy link
Author

AV3RG commented Jan 25, 2025

Thanks a lot @carlodrift. Was putting this off for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add update folder mechanism similar to what Bukkit servers do
6 participants