-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): auto updates #842
base: dev/3.0.0
Are you sure you want to change the base?
Conversation
proxy/src/main/java/com/velocitypowered/proxy/VelocityServer.java
Outdated
Show resolved
Hide resolved
3519d82
to
ea7d5c5
Compare
0cf2ef2
to
1ef0c01
Compare
proxy/src/main/java/com/velocitypowered/proxy/VelocityServer.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/plugin/VelocityPluginManager.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/VelocityServer.java
Outdated
Show resolved
Hide resolved
1ef0c01
to
708b634
Compare
This would be a great feature :) |
Is there any progress here? The Merge conflicts can be resolved easily, i rebased the branch and fixed the checkstyles in this branch: |
708b634
to
f23b66d
Compare
Not too sure how I did not get a notification for pending conflicts in this pull request and how I passed the check-style last time |
proxy/src/main/java/com/velocitypowered/proxy/plugin/VelocityPluginManager.java
Outdated
Show resolved
Hide resolved
f23b66d
to
d192d36
Compare
Hiiii, |
I'm using this on my server and it works fine. The implementation and the code looks fine. I'm not a reviewer here so I can't hit the approve button in github. But imo it should be ready to be merged. |
I'm gonna do it: |
proxy/src/main/java/com/velocitypowered/proxy/VelocityServer.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/plugin/VelocityPluginManager.java
Outdated
Show resolved
Hide resolved
Erm |
d192d36
to
d726583
Compare
Kind of conflicted on the usage of Do we wanna use streams here or should we revert back to |
Updated from upstream, resolved conflicts, and tested the changes—everything seems to be working fine: AV3RG#1 |
Resolve conflicts: Feat/update plugins
Thanks a lot @carlodrift. Was putting this off for a while. |
closes #809
TODO: