Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update audience operation support details in Velocity #470

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

Timongcraft
Copy link
Contributor

@Timongcraft Timongcraft commented Aug 19, 2024

  • Documented support for tablist headers, footers, and resource packs.
  • Clarified that unsupported operations include sounds and books. (currently the only unsupported operations)

Support for resource packs was added to the ConnectedPlayer class here.
Support for the tablist header and footer was added here.

Link to the original page: https://docs.papermc.io/velocity/dev/pitfalls#audience-operations-not-supported
Link to the page: https://timongcraft-fix-audience-api.papermc-docs.pages.dev/velocity/dev/pitfalls#audience-operations-are-not-fully-supported

Copy link

github-actions bot commented Aug 19, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview a89b385

@Leguan16
Copy link
Contributor

The table alone after a heading looks weird. I think some sort of introduction to why some operations are not supported would be nice to have.

Due to and Velocity currently only supports the following audience operations:

@Timongcraft
Copy link
Contributor Author

The table alone after a heading looks weird. I think some sort of introduction to why some operations are not supported would be nice to have.

Due to and Velocity currently only supports the following audience operations:

You mean a general introduction before the table, right, and not a description for each operation?

@Leguan16
Copy link
Contributor

Leguan16 commented Sep 1, 2024

The table alone after a heading looks weird. I think some sort of introduction to why some operations are not supported would be nice to have.

Due to and Velocity currently only supports the following audience operations:

You mean a general introduction before the table, right, and not a description for each operation?

Yes just a message before the table explaining why there are certain methods not implemented.

@Timongcraft
Copy link
Contributor Author

Is there anything from my side stopping this from being merged?

@zlataovce zlataovce merged commit 809f6d3 into PaperMC:main Sep 20, 2024
3 checks passed
@Timongcraft Timongcraft deleted the fix/audience-api-support branch September 20, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants