Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes some bad and old hallucinations #27984

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

DGamerL
Copy link
Member

@DGamerL DGamerL commented Jan 15, 2025

What Does This PR Do

With the wrap up of Paratoberfest, it's time to finish it up by removing a lot of the older hallucinations that were ... visually demaning or just quite bad in general

Removes the following hallucinations:
Minor:

  • The non-localized sounds, like the Halleluja or the summon weapons sting

Moderate:

  • Chasm
  • Delam sound
  • Fake item
  • Husks

Major:

  • Terror infestation

Why It's Good For The Game

Old hallucinations mostly bad, new hallucinations a lot better

Testing

It compiled


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
del: Removed some old hallucinations, check the PR for more details
/:cl:

@HMBGERDO
Copy link
Contributor

Removing terrors and leaving abductors? How about monkey attack? They are basically the same

also assaulter hallucination is broken and will always be a monkey instead of 20% because there is no else
image

is there some deeper reason why you remove terrors and dont remove these with them too?

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 15, 2025
@BiancaWilkson
Copy link
Contributor

This is definitely could be a personal thing, but the fake delam alarm has been one of the only hallucinations that legitimately sometimes fooled me, particularly playing engineering. I think it should stay.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 16, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 17, 2025
@Scribble-Sheep
Copy link
Contributor

Seconding the delamination one being good, it's lead to both me thinking a real delamination was a fake one for a second, or thinking that it was actually a delam.

@Piesuu
Copy link
Contributor

Piesuu commented Jan 20, 2025

Thirding the delamination one. Only hallucination to have actually fooled me

@Burzah Burzah added this pull request to the merge queue Jan 22, 2025
Merged via the queue into ParadiseSS13:master with commit 3e3837d Jan 22, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants