Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detective locker (wooden cabinet) resprite #27986

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

McRamon
Copy link
Contributor

@McRamon McRamon commented Jan 15, 2025

What Does This PR Do

resprites old sprite

Why It's Good For The Game

new sprite is better

Images of changes

image

Testing

looked at new sprites in game


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
imageadd: New sprites for wooden cabinet
/:cl:

@warriorstar-orion
Copy link
Contributor

I feel like it loses something without the brass knobs and decorative frame on the top of the closet. Otherwise looks good though.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Jan 15, 2025
@McRamon
Copy link
Contributor Author

McRamon commented Jan 16, 2025

I feel like it loses something without the brass knobs and decorative frame on the top of the closet. Otherwise looks good though.

generally both could be kept. it would require EFFORT to come up with good looking frame (because the one in the original sprite is barely a decorative frame and more of a noise), and knobs sadly intersect with the standard locked/unlocked light overlay which makes it awkward, so i imagined old fashioned looking cabinet with doors that open without a knob but instead when you press on them slightly. Either way, i guess i could add some golden details, or i could even get knobs back but id like to have custom light overlays (so they dont mess with the knobs) which i am not sure if easy to do

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 16, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants