Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookcase rework/resprite #28003

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

McRamon
Copy link
Contributor

@McRamon McRamon commented Jan 16, 2025

What Does This PR Do

  1. Reesprites basic wooden bookshelp
  2. adds 3 new bookcase types:
    a) metal bookscase - can be crafted with metal
    b) metal NT bookcase - can not be crafted. Will be mapped in (if accepted) into certain locations, such as NT office, CC etc.
    c) military bookcase - can be crafted from plasteel, has more sturdy "military" look. Can also be used later in mapping for locations where it would fit, such as syndicate bases, outposts, etc.
  3. reworks bookcase code in a way that books that appear on the sprite when books are placed on hte shelves, are now an overlay.

Why It's Good For The Game

More variety in style of furniture, better sprites than the old ones.

Images of changes

image

image

Testing

ran local server, constructed bookcases, deconstructed them, filled them with books to check different overlays working properly.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: 3 new bookcase types: metal(craftable), metal NT, plasteel(craftable)
imageadd: new sprites for wooden bookcase
/:cl:

Copy link
Contributor

@Fordoxia Fordoxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine.

Sprites look gorgeous.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team Sprites This PR modifies the game sprites labels Jan 16, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants