Remove ability to set monitoring log directory separate from rundir #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, MonitoringHub had a logdir parameter which let the log directory be set separately from the DFK-level run directory. Other Parsl components generally don't let the user set this unless there is a specific reason. So this PR removes that feature, reducing the amount of state to be threaded around. When reading this patch, note that what the DFK calls the rundir is a different directory vs what a Config object calls the rundir.
khk-globus
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, MonitoringHub had a logdir parameter which let the log directory be set separately from the DFK-level run directory.
Other Parsl components generally don't let the user set this unless there is a specific reason.
So this PR removes that feature, reducing the amount of state to be threaded around.
When reading this patch, note that what the DFK calls the rundir is a different directory vs what a Config object calls the rundir.
Changed Behaviour
This removes a parameter from user facing MonitoringHub configuration.
Type of change