Dexterity added to Minions instead of accuracy #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
The code for "Dead can Dance" was adding 5 accuracy directlly to minions per dex, instead of adding the dex to the minion. I feel it would be better to add to the minions Dex for clarity. It would be easy for a player to allocate the node, notice there is no Dexterity change in the minion, and then create an issue.
Also the possibility of further mods affecting minion attributes.
Steps taken to verify a working solution:
-Accuracy value added is the same after Dex is calculated for minion.
Link to a build that showcases this PR:
Before screenshot:
After screenshot: