Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guardian Elemental Relic support; #6768

Closed
wants to merge 1 commit into from

Conversation

Borisas
Copy link

@Borisas Borisas commented Sep 28, 2023

Adding support to enable/disable different auras from Guardian Elemental Relics for guardian.

@Borisas
Copy link
Author

Borisas commented Sep 28, 2023

forgot to include screenshots on how it works
image
image

@Regisle
Copy link
Member

Regisle commented Sep 28, 2023

Thank you for contributing, firstly the top of the other.lua file has -- This file is automatically generated, do not edit! as it gets overridden with data from the ggpk, the stuff you put in there are not exactly the correct way of doing it, you need to put stuff in other.txt and run the exporter, these likely need to be added as base mods instead due to how you can export stuff

Next the guardians relics auras technically do exist already they just are not applied to the player or minions (see #6745 for the fix), this doubles up on that, and your PR does not scale them by the level of the player/relic and is hardcoded which makes it a pain when the aura values do change

That being said the PR I mentioned earlier has the issue of only one aura being applied, the one from the active relic, this might be a bit much to ask of a new contributor, but investigating how to apply all 3 would be helpful

edit: another issue is the aura stacks with anger/wrath/hatred which it doesnt ingame because its the same aura ingame
it also gets effects from extra aura (eg unwavering faith) which it shouldnt, is increased by "auras from your skills have 10% increased effect on you" which it shouldnt because although the minion is your skill, the aura isnt

@Borisas
Copy link
Author

Borisas commented Sep 29, 2023

Thanks for the feedback, should've really spent more time reading rather than writing. Also seems he already made support for all auras. I'll keep your feedback in mind next time i want to add something.

@Borisas Borisas closed this Sep 29, 2023
@Borisas Borisas deleted the guardian-relic branch July 21, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants