Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sacrifice anomalous quality mod #6807

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

lepideble
Copy link
Contributor

@lepideble lepideble commented Oct 11, 2023

Description of the problem being solved:

The sacrifice anomalous quality isn't taken into account for cost calculation

Before screenshot:

image

After screenshot:

image

The `base_skill_cost_life_instead_of_mana_%` stat from sacrifice anomalous quality wasn't mapped and thus not taken into account for cost calculations.
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also want the mod HybridManaAndLifeCost_Mana, unless it works differently than the life mastery in game.

@lepideble
Copy link
Contributor Author

I've looked into it and it seems that HybridManaAndLifeCost_Mana isn't used for calculation and instead we use the complement of HybridManaAndLifeCost_Life: https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/dev/src/Modules/CalcOffence.lua#L1580

Should I still add it ? Or maybe we could simply remove the HybridManaAndLifeCost_Life mod ?

@LocalIdentity
Copy link
Contributor

@lepideble I'll make the required fixes on dev after I merge in this PR. I should have removed the other mod when I was fixing skill costs.
Have you tested this mod in-game to make sure the values are correct when using this mod with the life mastery and/or petrified blood?

@lepideble
Copy link
Contributor Author

I've tested it in game with only the gem and with the gem + the life mastery and the cost in PoB match the in game tooltip.

@Paliak Paliak added the enhancement New feature, calculation, or mod label Oct 27, 2023
@LocalIdentity LocalIdentity merged commit 9d80834 into PathOfBuildingCommunity:dev Dec 1, 2023
2 checks passed
@lepideble lepideble deleted the patch-1 branch December 4, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants