Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the refresh of markers with leaflet.refresh event #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mpeeters
Copy link
Contributor

No description provided.

@petschki
Copy link
Member

I could not find this event here https://leafletjs.com/reference.html#map-event ... does this work for you?

@mpeeters
Copy link
Contributor Author

Hi Peter,

this is a custom event that can be called to refresh the data, it is used by https://github.com/affinitic/collective.faceted.map to update the map data on each faceted query.

Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, +1 for this change.
But I'm a bit reserved when it comes to introduce another jQuery dependency. We currently only depend on jQuery in the moveend zoomend event handler.

Can we use native CustomEvent instead?

Also, please change your commit message to: feat: Handle the refresh of markers with leaflet.refresh event. That way we have it automatically added to the changelog. Also see: https://github.com/Patternslib/Patterns/blob/master/docs/developer/styleguide.md#commits-messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants