-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collaboration support #6
Draft
thet
wants to merge
13
commits into
master
Choose a base branch
from
scr-1709--collaboration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
force-pushed
the
scr-1709--collaboration
branch
2 times, most recently
from
February 3, 2022 21:05
5f97f35
to
4b61545
Compare
thet
force-pushed
the
scr-1709--collaboration
branch
from
February 18, 2022 08:46
4b61545
to
be6ec22
Compare
2 tasks
…s to work on the same document.
thet
force-pushed
the
scr-1709--collaboration
branch
from
September 26, 2023 23:46
0f701f4
to
72d0d14
Compare
…o is working on what section in the same document.
In our current implementation of the collaboration mode, there is a main connection. The main connection is the one first connecting to the collaboration server. This one reads the text from the textarea input field (or another strucutre) and passes it to the tiptap instance. If only the main connection updates the textdocument other clients connecting later will not overwrite the text. All clients are syncing changes back to the textarea input. This also means any client should be able to sumit the content back to the server. A future addition would be to get/set the text only through the collaboration server which always has the latest state. If this more sophisticated mehtod is really needed we will implement it later.
… collaboration server.
… DRAFT /1 NOTE: this would contradict the current mode where only what is defined in the toolbar is actually allowed as HTML. this is limiting! better, we define a default set of extension per mime type. this can then also be imported in the tiptap collaboration server to construct a valid representation of the content and be able to store that from there back to the backend.
thet
force-pushed
the
scr-1709--collaboration
branch
from
September 30, 2023 01:10
72d0d14
to
336ebd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.