Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified library to add RBGW support #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Modified library to add RBGW support #7

wants to merge 4 commits into from

Conversation

azzeloof
Copy link

Addresses Issue #5

azzeloof added 4 commits April 25, 2019 12:43
@azzeloof
Updated with jgastonraoul's fix
6c6c53b 
Modified to include  jgastonraoul's fix, which allows for RGBW LEDs, but does not allow for the white pixel to be enabled. See https://forum.pjrc.com/threads/49209-Non-blocking-library-for-RGBW-Neopixels
@azzeloof
Added full support for RGBW
13e3040 
Library now works for RGB and RGBW pixels
@azzeloof
Create RGBW_Test.ino
e1c5ed6
@azzeloof
Formatting
64c161b
@azzeloof azzeloof mentioned this pull request Apr 25, 2019
Closed
@avivey
Copy link

avivey commented May 19, 2019

@azzeloof I have a similar patch I was thinking of submitting - master...avivey:wrgb

In my version, I put a ledWidth member instead of dispSize and drawSize, and replace all the * 3 instances with * ledWidth (which is either 3 or 4). That way I don't need if (config == ...) in the cpp file (but instead I use if (ledWidth > 3)).

I also support WRGB lights, which is the stuff I happen to have :)

I don't have tests though :/

Do you maybe want to take some inspiration from my patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azzeloof @avivey