Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 1차 리팩토링 #62

Merged
merged 36 commits into from
Feb 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
440afa1
update: 닉네임을 입력하는 TextField에 좌우 margin 추가
kang9366 Feb 15, 2024
9c78503
chore: chore: dummy file created
kang9366 Feb 15, 2024
32d114b
rename: EmailLoginScreen -> NormalLoginScreen
kang9366 Feb 17, 2024
b988082
chore: LoginActivity 제거
kang9366 Feb 17, 2024
b2895aa
delete: ktlint Test 파일 제거
kang9366 Feb 17, 2024
3c1f3d4
delete: LoginActivity.kt 제거
kang9366 Feb 17, 2024
4430470
rename: LoginTypeScreen -> LoginScreen
kang9366 Feb 17, 2024
dccf27c
refactor: 수정된 변수명 반영
kang9366 Feb 17, 2024
22ff6e3
refactor: main 모듈에 대한 의존성 제거
kang9366 Feb 17, 2024
1fa72fe
chore: login 모듈에 대한 의존성 추가
kang9366 Feb 17, 2024
24caa7e
refactor: 변수명 수정 (NormalButton -> ConnectDogNormalButton)
kang9366 Feb 17, 2024
da329b6
refactor: 수정된 변수명 반영
kang9366 Feb 17, 2024
c98ebd3
refactor: 수정된 변수명 반영
kang9366 Feb 17, 2024
bb2111e
refactor: 수정된 변수명 반영
kang9366 Feb 17, 2024
2f0e8d5
refactor: 수정된 변수명 반영
kang9366 Feb 17, 2024
7fba11b
refactor: 수정된 변수명 반영
kang9366 Feb 17, 2024
30ae183
refactor: 수정된 변수명 반영
kang9366 Feb 17, 2024
3b2aa7a
refactor: 수정된 변수명 반영
kang9366 Feb 17, 2024
9a29c75
refactor: 변수명 및 navigator 방식 수정
kang9366 Feb 17, 2024
d9d13c0
chore: dummy file created
kang9366 Feb 17, 2024
52f87ea
style: 상수 추가
kang9366 Feb 17, 2024
b20983d
refactor: 수정된 변수명 반영
kang9366 Feb 17, 2024
f261c21
refactor: 수정된 변수명 반영
kang9366 Feb 17, 2024
ed2ac8b
refactor: 수정된 변수명 반영
kang9366 Feb 17, 2024
7f9f50f
refactor: 수정된 변수명 반영
kang9366 Feb 17, 2024
8f1a7e0
refactor: HiltViewModel로 변경
kang9366 Feb 17, 2024
10f8349
refactor: HiltViewModel로 변경
kang9366 Feb 17, 2024
cb11b13
refactor: navigator에 로그인, 봉사자, 중개자 타입을 전달
kang9366 Feb 17, 2024
580119c
refactor: 함수를 단일표현식으로 수정
kang9366 Feb 17, 2024
408b836
refactor: loginNavGraph 추가
kang9366 Feb 17, 2024
a6b2fc1
refactor: navigator 수정
kang9366 Feb 17, 2024
5ee8bcf
delete: 사용하지 않는 파일 삭제
kang9366 Feb 17, 2024
ff388a9
refactor: navigator 방식 수정
kang9366 Feb 17, 2024
08bf993
refactor: navigator 방식 수정
kang9366 Feb 17, 2024
3b2da7b
refactor: LoginNavigator 추가
kang9366 Feb 17, 2024
74983d7
refactor: VolunteerProfileViewModel 추가
kang9366 Feb 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
</activity>

<activity
android:name=".feature.LoginActivity"
android:name=".feature.main.MainActivity"
android:exported="true"
android:theme="@style/Theme.ConnectDog.Splash">
<intent-filter>
Expand All @@ -41,10 +41,6 @@
<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
</activity>
<activity
android:name=".feature.main.MainActivity"
android:exported="true">
</activity>
<activity
android:name=".feature.intermediator.IntermediatorActivity"
android:exported="true">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ fun ConnectDogIconBottomButton(
}

@Composable
fun NormalButton(
fun ConnectDogNormalButton(
content: String,
color: Color = MaterialTheme.colorScheme.primary,
onClick: () -> Unit = {},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ import androidx.compose.ui.unit.sp
import androidx.hilt.navigation.compose.hiltViewModel
import com.kusitms.connectdog.core.data.api.model.volunteer.ApplyBody
import com.kusitms.connectdog.core.designsystem.R
import com.kusitms.connectdog.core.designsystem.component.ConnectDogNormalButton
import com.kusitms.connectdog.core.designsystem.component.ConnectDogTopAppBar
import com.kusitms.connectdog.core.designsystem.component.NormalButton
import com.kusitms.connectdog.core.designsystem.component.NormalTextField
import com.kusitms.connectdog.core.designsystem.component.TopAppBarNavigationType
import com.kusitms.connectdog.core.designsystem.theme.Gray2
Expand Down Expand Up @@ -158,7 +158,7 @@ private fun Content(
onTextChanged = onContentChanged
)

NormalButton(
ConnectDogNormalButton(
content = "완료",
onClick = {
viewModel.postApplyVolunteer(
Expand All @@ -176,24 +176,6 @@ private fun Content(
}
}

// @Composable
// private fun BottomButton(
// onClick: () -> Unit,
// ) {
// Box(
// modifier = Modifier
// .fillMaxWidth()
// .height(112.dp)
// .background(Color.White)
// ) {
// Row(
// modifier = Modifier.align(Alignment.Center)
// ) {
//
// }
// }
// }

@Composable
fun NoticeCard() {
Card(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,10 @@ import androidx.compose.ui.text.input.KeyboardType
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import androidx.hilt.navigation.compose.hiltViewModel
import androidx.lifecycle.viewmodel.compose.viewModel
import com.kusitms.connectdog.core.designsystem.R
import com.kusitms.connectdog.core.designsystem.component.ConnectDogNormalButton
import com.kusitms.connectdog.core.designsystem.component.ConnectDogTextFieldWithButton
import com.kusitms.connectdog.core.designsystem.component.ConnectDogTopAppBar
import com.kusitms.connectdog.core.designsystem.component.NormalButton
import com.kusitms.connectdog.core.designsystem.component.NormalTextField
import com.kusitms.connectdog.core.designsystem.component.TopAppBarNavigationType
import com.kusitms.connectdog.core.designsystem.theme.Orange40
Expand Down Expand Up @@ -130,7 +129,7 @@ private fun Content(
}
)
Spacer(modifier = Modifier.weight(1f))
NormalButton(
ConnectDogNormalButton(
content = "다음",
color = buttonColor,
modifier = Modifier
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import com.kusitms.connectdog.core.designsystem.R
import com.kusitms.connectdog.core.designsystem.component.NormalButton
import com.kusitms.connectdog.core.designsystem.component.ConnectDogNormalButton
import com.kusitms.connectdog.core.designsystem.theme.ConnectDogTheme
import com.kusitms.connectdog.core.designsystem.theme.Gray2

Expand Down Expand Up @@ -83,7 +83,7 @@ fun CompleteApplyScreen(
color = Gray2
)
}
NormalButton(
ConnectDogNormalButton(
content = "확인",
modifier =
Modifier
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ import androidx.compose.ui.unit.sp
import androidx.hilt.navigation.compose.hiltViewModel
import com.kusitms.connectdog.core.data.api.model.volunteer.NoticeDetailResponseItem
import com.kusitms.connectdog.core.designsystem.component.ConnectDogInformationCard
import com.kusitms.connectdog.core.designsystem.component.ConnectDogNormalButton
import com.kusitms.connectdog.core.designsystem.component.ConnectDogTag
import com.kusitms.connectdog.core.designsystem.component.ConnectDogTopAppBar
import com.kusitms.connectdog.core.designsystem.component.DetailInfo
import com.kusitms.connectdog.core.designsystem.component.NetworkImage
import com.kusitms.connectdog.core.designsystem.component.NormalButton
import com.kusitms.connectdog.core.designsystem.component.TopAppBarNavigationType
import com.kusitms.connectdog.core.designsystem.theme.Gray2
import com.kusitms.connectdog.core.designsystem.theme.Gray5
Expand Down Expand Up @@ -298,7 +298,7 @@ private fun BottomButton(
) {
BookmarkButton(isBookmark, onSaveClick, onDeleteClick)
Spacer(modifier = Modifier.width(10.dp))
NormalButton(content = "신청하기", onClick = onClick)
ConnectDogNormalButton(content = "신청하기", onClick = onClick)
}
}
}
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import androidx.lifecycle.LiveData;
import androidx.lifecycle.MutableLiveData;
import androidx.lifecycle.ViewModel;
import com.kusitms.connectdog.core.data.api.model.intermediator.IntermediatorInfoResponseItem;
import com.kusitms.connectdog.core.data.api.model.intermediator.IntermediatorProfileInfoResponseItem;
import com.kusitms.connectdog.core.data.repository.InterManagementRepository;
import com.kusitms.connectdog.core.model.DataUiState;
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ import com.google.accompanist.pager.ExperimentalPagerApi
import com.google.accompanist.pager.HorizontalPager
import com.google.accompanist.pager.rememberPagerState
import com.kusitms.connectdog.core.designsystem.component.ConnectDogInformationCard
import com.kusitms.connectdog.core.designsystem.component.ConnectDogNormalButton
import com.kusitms.connectdog.core.designsystem.component.ConnectDogOutlinedButton
import com.kusitms.connectdog.core.designsystem.component.ConnectDogTopAppBar
import com.kusitms.connectdog.core.designsystem.component.DetailInfo
import com.kusitms.connectdog.core.designsystem.component.NetworkImage
import com.kusitms.connectdog.core.designsystem.component.NormalButton
import com.kusitms.connectdog.core.designsystem.component.TopAppBarNavigationType
import com.kusitms.connectdog.core.designsystem.theme.ConnectDogTheme
import com.kusitms.connectdog.core.designsystem.theme.Gray1
Expand Down Expand Up @@ -156,7 +156,7 @@ private fun Information() {
) {
IntermediatorInformation()
Spacer(modifier = Modifier.weight(1f))
NormalButton(content = "수정하기", modifier = Modifier.fillMaxWidth().padding(horizontal = 20.dp))
ConnectDogNormalButton(content = "수정하기", modifier = Modifier.fillMaxWidth().padding(horizontal = 20.dp))
Spacer(modifier = Modifier.height(32.dp))
}
}
Expand Down
1 change: 0 additions & 1 deletion feature/login/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ android {

dependencies {

implementation(project(":feature:main"))
implementation(project(":core:designsystem"))
implementation(project(":core:util"))
implementation(project(":feature:intermediator"))
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
package com.kusitms.connectdog.feature.login

import androidx.navigation.NavController
import androidx.navigation.NavGraphBuilder
import androidx.navigation.compose.composable
import com.kusitms.connectdog.feature.signup.VolunteerSignupScreen

fun NavController.navigateLogin() {
navigate(LoginRoute.route)
}

fun NavController.navigateSignup() {
navigate(LoginRoute.signup)
}

fun NavController.navigateNormalLogin() {
navigate(LoginRoute.normal_login)
}

fun NavGraphBuilder.loginNavGraph(
onBackClick: () -> Unit,
onNavigateToNormalLogin: () -> Unit,
onNavigateToVolunteer: () -> Unit,
onNavigateToSignup: () -> Unit
) {
composable(route = LoginRoute.route) {
LoginRoute(
onNavigateToNormalLogin,
onNavigateToSignup
)
}

composable(route = LoginRoute.normal_login) {
NormalLoginScreen(
onBackClick = onBackClick,
initVolunteer = {},
initIntermediator = {},
test = onNavigateToVolunteer
)
}

composable(route = LoginRoute.signup) {
VolunteerSignupScreen(
// onBackClick = onBackClick
)
}
}

object LoginRoute {
const val route = "login"
const val normal_login = "normal_login"
const val signup = "signup"
}
Loading
Loading