Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session-id parameter #1379

Merged
merged 10 commits into from
Feb 10, 2025
Merged

Add session-id parameter #1379

merged 10 commits into from
Feb 10, 2025

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 5, 2025

Closes #1377.

Changes proposed in this pull request

  • Add --session-id parameter to CLI. The session_id variable is passed along into all of the BIDS filters. A value of Query.NONE is also passed along, primarily for anatomical data that might not be at the session level.

@tsalo tsalo added the enhancement New feature or request label Feb 5, 2025
@tsalo tsalo changed the title Add session-id parameter. Add session-id parameter Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.49%. Comparing base (a991b8d) to head (a2bcf88).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
xcp_d/reports/core.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
+ Coverage   78.44%   78.49%   +0.05%     
==========================================
  Files          58       58              
  Lines        7288     7305      +17     
  Branches      959      962       +3     
==========================================
+ Hits         5717     5734      +17     
- Misses       1291     1292       +1     
+ Partials      280      279       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Member Author

tsalo commented Feb 6, 2025

I should update the CLI parsing tests too.

@tsalo tsalo marked this pull request as ready for review February 7, 2025 19:10
@tsalo tsalo requested a review from mattcieslak February 7, 2025 19:11
Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of any reasons why this wouldn't work, and you added a test where it's used, so I say this is good to go

@tsalo tsalo merged commit 52552ad into main Feb 10, 2025
24 checks passed
@tsalo tsalo deleted the session-id branch February 10, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --session-id argument
2 participants