-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add session-id parameter #1379
Add session-id parameter #1379
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1379 +/- ##
==========================================
+ Coverage 78.44% 78.49% +0.05%
==========================================
Files 58 58
Lines 7288 7305 +17
Branches 959 962 +3
==========================================
+ Hits 5717 5734 +17
- Misses 1291 1292 +1
+ Partials 280 279 -1 ☔ View full report in Codecov by Sentry. |
I should update the CLI parsing tests too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of any reasons why this wouldn't work, and you added a test where it's used, so I say this is good to go
Closes #1377.
Changes proposed in this pull request
--session-id
parameter to CLI. Thesession_id
variable is passed along into all of the BIDS filters. A value ofQuery.NONE
is also passed along, primarily for anatomical data that might not be at the session level.