Merge pull request #3 from Permian-Global-Research/asset-name-bug

not all assets are named dataset - adding elevation
Permian-Global-Research · Oct 11, 2024 · 8065dbe · 8065dbe
2 parents 545d733 + 4431eb9
commit 8065dbe
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/R/mpc_srcs.R b/R/mpc_srcs.R
@@ -63,7 +63,12 @@ mpc_dtm_src <- function(aoi,
 
   if (isTRUE(sign_items)) it_obj <- sign_mpc(it_obj, subscription_key)
 
-  urls <- rstac::assets_url(it_obj, "data")
+  # select either elevation or data, whicever present
+  av_assets <- rstac::items_assets(it_obj)
+  desired_assets <- c("data", "elevation")
+  selected_asset <- intersect(av_assets, desired_assets)[1]
+
+  urls <- rstac::assets_url(it_obj, selected_asset)
 
   if (isTRUE(vsicurl)) {
     urls <- sapply(

diff --git a/tests/testthat/test-mpc_srcs.R b/tests/testthat/test-mpc_srcs.R
@@ -17,4 +17,16 @@ test_that("mpc_dtm_src works", {
 
   nc_urls_nokey <- mpc_dtm_src(nc_sf, subscription_key = "")
   expect_equal(length(nc_urls_nokey), 37)
+
+  box <- c(-121.772, 45.321, -121.611, 45.419)
+
+  lapply(c(
+    "cop-dem-glo-30", "cop-dem-glo-90",
+    "alos-dem", "nasadem"
+  ), function(x) {
+    expect_silent(
+      durl <- mpc_dtm_src(box, collection = x)
+    )
+    expect_true(length(durl) > 0)
+  })
 })