Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Works of James I (from branch P6) #7

Merged
merged 26 commits into from
Jun 12, 2024
Merged

Works of James I (from branch P6) #7

merged 26 commits into from
Jun 12, 2024

Conversation

cwulfman
Copy link
Collaborator

@cwulfman cwulfman commented Jun 4, 2024

In P4, there was a single XML document for an edition of James I's political works. I have broken this edition into separate documents, one for each work, each with a RefsDecl tuned to its structure.

All pass the HookTests. The encoding is minimal, and a good deal of work remains to be done to enable linking.

@cwulfman cwulfman requested a review from lcerrato June 4, 2024 14:15
</ti:title>
<ti:edition urn="urn:cts:engLit:james1.apology.perseus-eng1" workUrn="urn:cts:engLit:james1.apology" xml:lang="eng">
<ti:label xml:lang="eng">The Triplici Nodo, Triplex Cuneus. Or An Apologie For The Oath Of Allegiance</ti:label>
<ti:description xml:lang="eng">The Triplici Nodo, Triplex Cuneus. Or An Apologie For The Oath Of Allegiance</ti:description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the description in each work file we typically include a description of the edition rather than a repeat of the work name, for all of these cts_.xml work files I would suggest: James I. The Political Works of James I: Reprinted from the Edition of 1616. McIlwain, Charles Howard, editor. Cambridge: Harvard University Press, 1918.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @cwulfman I have a few comments (none of which have to do with encoding or structure) on the header.

  1. In general we no longer encode editor twice, so instead of
    <editor role="editor">Charles Howard McIlwain</editor> we would just have
    <editor>Charles Howard McIlwain</editor>

  2. There is a typo in the title <title>The Politial Works of James I: Reprinted from the Edition of 1616</title> I think you mean "Political"

  3. At the end of the structured bibl data we are no trying to add links for all works/editions to image books in online collections such as the Internet Archive or HathiTrust, so for example for this work, after the close of the <monogr> you could add:
    <ref target="https://hdl.handle.net/2027/mdp.39015003479154?urlappend=%3Bseq=119%3Bownerid=13510798890611502-123>HathiTrust</ref>

  4. In the <revisionDesc> you should add yourself considering the amount of work you did to this file, perhaps:
    <change when="2024-06-03" who="Cliff Wulfman">Epidoc conversion and all matter of changes</change>

Just some first thoughts.

@cwulfman
Copy link
Collaborator Author

cwulfman commented Jun 4, 2024

I also just discovered a bug in my Unicode entity converter, so I'll have to go back and fix those.

@lcerrato
Copy link
Contributor

lcerrato commented Jun 4, 2024

In general I should note that the <respStmt> and <date type="release" when="..." cert="...">...</date> are reviewed for each Perseus file. So what applies in one case is not necessarily true of another.

I research using the release history info on the site and the staff info I have on hand.

If this is uncertain, best to leave a place holder or ask for more research.

@lcerrato
Copy link
Contributor

lcerrato commented Jun 5, 2024

@cwulfman If the metadata is ok with @AlisonBabeu we can go ahead with these.

I would only suggest that the xml:base be added if these are flat and it is quick and easy.
https://github.com/OpenGreekAndLatin/First1KGreek/wiki/CTS-URNs:-Using-the-xml:base-attribute-in-CTS-divs

Copy link
Contributor

@lcerrato lcerrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything major here but have not extensively viewed each file. You may want to combine some tags if it is the case that the Latin is italicized because it is Latin
<hi rend="italic"><foreign xml:lang="lat"> could be <foreign xml:lang="lat" rend="italic"> as the italic tags have no other obvious semantic meaning here.
That could be a later refinement, though.

@AlisonBabeu
Copy link
Contributor

hi @cwulfman and @lcerrato the metadata changes to title and cts look good.

@cwulfman cwulfman merged commit d6e9d10 into main Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants