Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Package Builder for dlang projects #66

Open
wants to merge 55 commits into
base: main
Choose a base branch
from

Conversation

monyarm
Copy link
Collaborator

@monyarm monyarm commented Apr 14, 2024

The goal of this PR is to create a package builder similiar to buildNpmPackage, buildRustPackage, buildGoPackage and others.

A loose summary of necessary subtasks would be:

  • Keep the source code of Dub, so it can later be added as a search path.
  • Create a script (with Nix, dlang or bash), which will download the names and versions of each dub package, generate hashes, and output it to a json file.
  • Create a CI job with a cron job to run weekly, and run the above script, creating a PR when it does.
  • Create a basic buildDubPackage function, which can build dependencyless projects.
  • Add dub.selections.json dependency resolution
  • If dub.selections.json doesn't exist in the repo, require it to be manually supplied.
  • Allow choice of dub version
  • Implement test running
  • Create packages for a number of popular dlang projects, to serve as an example of buildDubPackage
  • Write proper documentation for buildDubPackage
  • Ask @PetarKirov for a code review, and additional suggestions

See #64 for old version

@monyarm monyarm mentioned this pull request Apr 14, 2024
11 tasks
@monyarm monyarm force-pushed the feat/build-dub-package branch 4 times, most recently from f5f8d59 to eeb8a20 Compare April 14, 2024 22:56
@monyarm monyarm force-pushed the feat/build-dub-package branch from b126b79 to 062d517 Compare April 14, 2024 23:28
@dukc
Copy link
Collaborator

dukc commented Apr 22, 2024

Impressive work to do all this in such a short time, especially if you really did this all on your own time!

However, I have an issue. I don't think we should include every DUB package as a nix derivation here. It means that anyone who clones this repo has to download all 2K+ of them.

A script to generate them oneself is fine, if we want to go further we can make another repo to cache the generated DUB package derivations.

ping @PetarKirov @monyarm .

Copy link

Thanks for your Pull Request!

This comment will be updated automatically with the status of each package.

@dukc
Copy link
Collaborator

dukc commented May 4, 2024

ping @monyarm
All items in the list are checked. Does it mean it's ready for review now?

ping @PetarKirov
Your comments also wanted. Or have you already reviewed this offline?

@dukc
Copy link
Collaborator

dukc commented Sep 24, 2024

@monyarm @PetarKirov What's the status on this one now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants