Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pause input ingestion halfway through Grace period #33

Open
wants to merge 3 commits into
base: 2_33_awsbase
Choose a base branch
from
Open

Pause input ingestion halfway through Grace period #33

wants to merge 3 commits into from

Conversation

PettitWesley
Copy link
Owner

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@PettitWesley
engine: input grace period delay shutdown for pending tasks & chunks
362aa77 
1. Input grace period

Currently, Fluent Bit pauses all inputs 1 second after SIGTERM. The change creates an input grace period, which by default is one half the total Grace setting. This means that half way through the grace period Fluent Bit stops accepting any new logs and only sends logs pending in the buffers.

2. Check pending chunks on shutdown
Previously the engine shutdown immediately if there were no
pending tasks. A task is created from a chunk in the buffer.
If there is a new chunk, but no task yet, the engine should
keep running until the task is created and completed.

This change makes the engine wait on shutdown for all
pending chunks until the max grace period has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PettitWesley