Refactored Animatable into the element tree and fixed some bugs #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having Animatables in vhe view has some issues, e.g. memoize doesn't work. (It was never planned to keep it there anyway, but for simplicity it was done like this for now) It also requires for each animation update to rerender the whole view. (This happens currently non-the-less, but can be changed in the future) This moves the Animatable and Tweenable logic into the element tree, and adds a new ChangFlag `ANIMATION`. `Animatable` and `Tweenable` slowly converge back to `View` traits And can thus be genereated as such to have support for other core views like memoize etc. :). There were also a few issues with pods not being marked (`Pod::mark`) in the owner views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having Animatables in vhe view has some issues, e.g. memoize doesn't work.
(It was never planned to keep it there anyway, but for simplicity it was done like this for now)
It also requires for each animation update to rerender the whole view.
(This happens currently non-the-less, but can be changed in the future)
This moves the Animatable and Tweenable logic into the element tree, and adds a new ChangeFlag
ANIMATION.AnimatableandTweenableslowly converge back toViewtraits And can thus be genereated as such to have support for other core views like memoize etc. :).There were also a few issues with pods not being marked (
Pod::mark) in the owner views