Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Update Trajectory Template and Uniform Trajectory Modifications #1463

Merged

Conversation

CrimRecya
Copy link
Contributor

Update the old template of Trajectory=Sample, add some comments. And make some uniform changes for Trajectories: 1. Avoid inertia effect on trajectories fired by aircrafts; 2. Draw laser trails with the actual moving direction of the projectile.

@github-actions github-actions bot added the Minor Documentation is not required label Dec 26, 2024
Copy link

github-actions bot commented Dec 26, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Copy link
Contributor

@chaserli chaserli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also have some other common changes in your trajectory prs. Copy them here so that we can process them together.

@CrimRecya
Copy link
Contributor Author

You also have some other common changes in your trajectory prs. Copy them here so that we can process them together.

I have picked out the most common part. Please check it out.

@chaserli chaserli self-assigned this Dec 29, 2024
Copy link
Contributor

@Coronia Coronia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this isn't a real function, think it could be merged safely

@CrimRecya CrimRecya merged commit 68e222a into Phobos-developers:develop Jan 15, 2025
6 checks passed
@CrimRecya CrimRecya deleted the develop-trajectory-sample branch January 19, 2025 13:50
FS-21 pushed a commit to FS-21/Phobos that referenced this pull request Feb 18, 2025
…ns (Phobos-developers#1463)

Update the old template of `Trajectory=Sample`, add some comments.
And make some uniform changes for Trajectories:
1. Avoid inertia effect on trajectories fired by aircrafts;
2. Now trajectory projectile will only use positive speed;
3. Draw laser trails with the actual moving direction of the projectile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Documentation is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants