Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Customized] Avoid weapon fire overflow in the same frame #1472

Closed

Conversation

CrimRecya
Copy link
Contributor

  • Now you can make the weapon declare that the target has been locked at the moment of firing, and all weapons with positive NoRepeatFire value will not attack the declared target again during this period of time. Made for seckill and control weapons.

In rulesmd.ini:

[SOMEWEAPON]       ; WeaponType
NoRepeatFire=0     ; integer, game frames

Copy link

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@CrimRecya
Copy link
Contributor Author

If the techno can attach effect to the target at the moment of firing, it can achieve a similar effect. But I am not sure whether it needs to be expanded. It seems that there are not many places suitable for this.

@Aephiex
Copy link
Contributor

Aephiex commented Dec 28, 2024

Now you can make the weapon declare that the target has been locked at the moment of firing, and all weapons with positive NoRepeatFire value will not attack the declared target again during this period of time. Made for seckill and control weapons.

Maybe change that to only the weapons in a specific group?


### Avoid weapon fire overflow in the same frame

- Now you can make the weapon declare that the target has been locked at the moment of firing, and all weapons with positive `NoRepeatFire` value will not attack the declared target again during this period of time. Made for seckill and control weapons.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the tag to something like PreventTargetDuration for better clarification

  • what it can stop is the targeting process, but not the real damage
  • it's supposed to be an integer tag for frame amount, instead of a boolean one

@Coronia
Copy link
Contributor

Coronia commented Jan 15, 2025

Now you can make the weapon declare that the target has been locked at the moment of firing, and all weapons with positive NoRepeatFire value will not attack the declared target again during this period of time. Made for seckill and control weapons.

Maybe change that to only the weapons in a specific group?

I think we can already use new AEs for that. This avoid fire logic should remain simple as it is imo

@CrimRecya
Copy link
Contributor Author

#1482 can complete this implement in a more customized way, so I decided to turn this off.

@CrimRecya CrimRecya closed this Jan 15, 2025
@CrimRecya CrimRecya deleted the develop-NoRepeatFire branch January 17, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants