Retry packets on timeouts and other failures #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every command and reply in stk500 starts with 0x1b. When another byte was received, before the serial read was aborted and an error message was shown. However, since cbStep() doesn't do string formatting, the variable part of the message (the actual byte received) was hidden. This fixes that error message and continues to look for a 0x1b on an error, which might make things slightly more reliable.
Previously, a receive timeout seemd to just end the loop, returning an empty packet.
It seems that our bootloader times out after around 600ms, so lowering the timeout to this ensures we get a chance to do a retry before it times out and boots the sketch.
|
This PR also lowers the timeout to 500ms, but there's a chance that's not enough for the signon command, so that should get a higher timeout or also retries (OTOH, if the bootloader isn't running yet by the time the signon command is sent, increasing the timeout doesn't actually help, so it's probably fine like this). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to fix Pinoccio/server-hq#191, this PR adds retries for pagedWrite commands. It's completely untested and should probably be generalized, but it might just work...
@jingman, @quartzjer, could you have a go with this code? I'm out of time for today (and probably tomorrow too).